Gabor/typtbl #5693
Open
Gabor/typtbl #5693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggreif
commented
Dec 1, 2025
| const WORD_SIZE: usize = core::mem::size_of::<u32>(); | ||
|
|
||
| if (*buf).ptr.add(WORD_SIZE - 1) >= (*buf).end { | ||
| if (*buf).ptr.add(WORD_SIZE) > (*buf).end { |
Contributor
Author
There was a problem hiding this comment.
this is equivalent, but can CSE with below
ggreif
commented
Dec 1, 2025
| #[no_mangle] | ||
| unsafe extern "C" fn idl_sub_buf_words(typtbl_size1: usize, typtbl_size2: usize) -> usize { | ||
| return BitRel::words(typtbl_size1, typtbl_size2); | ||
| BitRel::words(typtbl_size1, typtbl_size2) |
ggreif
commented
Dec 1, 2025
| let idl_value_numerator = 1l | ||
| let idl_value_denominator = 1l | ||
| let idl_value_bias = 1024l | ||
| let idl_type_scaler = 3l |
Contributor
Author
There was a problem hiding this comment.
s/idl_type_/idl_typetbl_/g
Contributor
Author
There was a problem hiding this comment.
Maybe we should have {scaler = 1; bias = 512}, I am not sure about the current defaults.
Collaborator
There was a problem hiding this comment.
probably fine to have a larger default;
ggreif
commented
Dec 1, 2025
| E.add_global32 env "@@value_bias" Mutable idl_value_bias; | ||
| E.add_global64 env "@@value_quota" Mutable 0L | ||
| E.add_global64 env "@@value_quota" Mutable 0L; | ||
| E.add_global32 env "@@type_scaler" Mutable idl_type_scaler; |
| }; | ||
| }; | ||
| func setCandidTypeLimits<system>({ |
Collaborator
There was a problem hiding this comment.
exposing this method to the user seems like a bit too much power/opportunity to do wrong things; no strong opinions but I wonder if this shouldn't perhaps be more like a compile-time setting, perhaps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.