fix: bundle state manager and state dir together in StateMachine tests #7845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
added
the
CI_ALL_BAZEL_TARGETS
derlerd-dfinity
approved these changes
Nov 28, 2025
Contributor
derlerd-dfinity
left a comment
derlerd-dfinity
left a comment
There was a problem hiding this comment.
Thanks a lot. LGTM.
schneiderstefan
approved these changes
Nov 28, 2025
adambratschikaye
approved these changes
Dec 1, 2025
mraszyk
added a commit
that referenced
this pull request
Dec 1, 2025
#7845) This PR bundles the state manager and the state directory (on disk) together in StateMachine tests so that the state directory cannot be dropped (and consequently deleted) before the state manager has been dropped (i.e., shut down completely).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bundles the state manager and the state directory (on disk) together in StateMachine tests so that the state directory cannot be dropped (and consequently deleted) before the state manager has been dropped (i.e., shut down completely).