Skip to content

misc: PR to compare the rollout chart changes for 5.1.1 #6875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

misc: PR to compare the rollout chart changes for 5.1.1 #6875

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b3ae5e
PR to compare the rollout chart changes
akshatsinha007 Nov 27, 2025
d5b887b
added migrations
akshatsinha007 Nov 27, 2025
3e022b7
added name = 'Rollout Deployment'
akshatsinha007 Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/devtron-reference-helm-charts/reference-chart_5-1-0/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v1
appVersion: "1.0"
description: A Helm chart for Kubernetes
name: reference-chart_5-1-0
version: 5.1.0
name: reference-chart_5-1-1
version: 5.1.1
2 changes: 1 addition & 1 deletion scripts/devtron-reference-helm-charts/reference-chart_5-1-0/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

# Rollout Deployment Chart - v5.0
# Rollout Deployment Chart - v5.1

## 1. Yaml File -

Expand Down
4 changes: 3 additions & 1 deletion scripts/devtron-reference-helm-charts/reference-chart_5-1-0/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,10 +750,12 @@ spec:
- {{ . }}
{{- end }}
{{- end }}
{{- else if .Values.deployment.strategy.canary.trafficRouting.customTrafficRouting }}
{{ toYaml .Values.deployment.strategy.canary.trafficRouting.customTrafficRouting | indent 8 }}
{{- end }}
{{- if .Values.deployment.strategy.canary.trafficRouting.managedRoutes }}
managedRoutes:
{{ toYaml .Values.deployment.strategy.canary.trafficRouting.managedRoutes | indent 10 }}
{{ toYaml .Values.deployment.strategy.canary.trafficRouting.managedRoutes | indent 10 }}
{{- end }}
{{- end }}
{{- end }}
10 changes: 9 additions & 1 deletion scripts/devtron-reference-helm-charts/reference-chart_5-1-0/templates/externalsecrets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@
{{if (or (eq .externalType "ESO_GoogleSecretsManager") (eq .externalType "ESO_AWSSecretsManager") (eq .externalType "ESO_HashiCorpVault") (eq .externalType "ESO_AzureSecretsManager"))}}
{{- if .esoSecretData.secretStore }}
---
{{- if $.Capabilities.APIVersions.Has "external-secrets.io/v1" }}
apiVersion: external-secrets.io/v1
{{- else }}
apiVersion: external-secrets.io/v1beta1
{{- end }}
kind: SecretStore
metadata:
name: {{ .name}}
Expand All @@ -22,7 +26,11 @@ spec:
{{- toYaml .esoSecretData.secretStore | nindent 4 }}
{{- end }}
---
apiVersion: external-secrets.io/v1beta1
{{- if $.Capabilities.APIVersions.Has "external-secrets.io/v1" }}
apiVersion: external-secrets.io/v1
{{- else }}
apiVersion: external-secrets.io/v1beta1
{{- end }}
kind: ExternalSecret
metadata:
name: {{ .name }}
Expand Down
3 changes: 3 additions & 0 deletions .../devtron-reference-helm-charts/reference-chart_5-1-0/templates/istio-destinationrule.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ metadata:
{{- else }}
name: {{ template ".Chart.Name .fullname" $ }}-destinationrule
{{- end }}
{{- if .destinationRule.namespace }}
namespace: {{ .destinationRule.namespace }}
{{- end }}
labels:
app: {{ template ".Chart.Name .name" $ }}
appId: {{ $.Values.app | quote }}
Expand Down
3 changes: 3 additions & 0 deletions ...s/devtron-reference-helm-charts/reference-chart_5-1-0/templates/istio-virtualservice.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ metadata:
{{- else }}
name: {{ template ".Chart.Name .fullname" $ }}-virtualservice
{{- end }}
{{- if .virtualService.namespace }}
namespace: {{ .virtualService.namespace }}
{{- end }}
labels:
app: {{ template ".Chart.Name .name" $ }}
appId: {{ $.Values.app | quote }}
Expand Down
8 changes: 6 additions & 2 deletions scripts/devtron-reference-helm-charts/reference-chart_5-1-0/test_values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,12 @@ deployment:
- pause: {} # final manual approval (optional)

trafficRouting:
# managedRoutes:
# - name: api-canary
managedRoutes:
- name: api-canary
devtron: test
customTrafficRouting:
nginx:
stableIngress: rollouts-demo-stable
istio:
virtualService:
name: api-vs
Expand Down