Add new logo; update footer for OS2 #93
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -143,9 +143,7 @@ | |
| } | ||
|
|
||
| #nav-oddk-title { | ||
| max-height: 38px !important; | ||
| } | ||
|
|
||
| #nav-search-mag-glass { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,7 +33,7 @@ | |
| <header class="header-color" style="background-color: #f5f5f5;"> | ||
| <div class="container mx-auto lg:flex justify-between items-center relative"> | ||
| <a href="/" class="flex content-center items-center h-6 mr-16 p-gutter" aria-label="{{__('Navigate')}} {{__('Home')}}" id="nav-oddk-logo"> | ||
| <img src="/static/img/[email protected]" alt="OS2 logo" id="nav-oddk-title"/> | ||
|
Comment on lines
35
to
+36
There was a problem hiding this comment. Remove duplicate IDs from header and footer logo sections. Both the header logo (lines 35–36) and footer logo (lines 82–83) use identical IDs ( Apply this diff to make footer IDs unique: <div class="px-gutter md:p-gutter md:w-2/4">
<div>
- <a href="/" class="flex content-center items-center h-6 mr-16 p-gutter" aria-label="{{__('Navigate')}} {{__('Home')}}" id="nav-oddk-logo">
- <img src="/static/img/[email protected]" alt="OS2 logo" id="nav-oddk-title" />
+ <a href="/" class="flex content-center items-center h-6 mr-16 p-gutter" aria-label="{{__('Navigate')}} {{__('Home')}}" id="footer-oddk-logo">
+ <img src="/static/img/[email protected]" alt="OS2 logo" id="footer-oddk-title" />
</a>
</div>
</div>Also applies to: 82-83 🤖 Prompt for AI Agents |
||
| </a> | ||
|
|
||
| <button id="nav-toggle" class="absolute top-0 right-0 outline-none focus:outline-none focus:text-secondary lg:hidden invisible"> | ||
|
|
@@ -44,9 +44,6 @@ | |
|
|
||
| <nav class="main-nav mt-4 py-2 lg:my-2 right-0 z-10 lg:relative" aria-label="{{__('Website navigation')}}"> | ||
| <ul class="lg:flex md:text-xl lg:text-2xl"> | ||
| <li class="main-nav_item lg:mx-3"> | ||
| <a class="main-nav_link" href="/blog">{{__('News')}}</a> | ||
| </li> | ||
|
|
@@ -80,18 +77,34 @@ | |
| <!-- Footer --> | ||
| <footer class="site-footer bg-primary text-white-75 mt-10 py-gutter text-sm"> | ||
| <div class="container mx-auto md:flex md:justify-between"> | ||
| <div class="px-gutter md:p-gutter md:w-2/4"> | ||
| <div> | ||
| <a href="/" class="flex content-center items-center h-6 mr-16 p-gutter" aria-label="{{__('Navigate')}} {{__('Home')}}" id="nav-oddk-logo"> | ||
| <img src="/static/img/[email protected]" alt="OS2 logo" id="nav-oddk-title" /> | ||
| </a> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="px-gutter md:p-gutter md:w-1/4"> | ||
| <div> | ||
| <p> | ||
| <span class="home-about-text" id="home-about-text-stacked-top">{{ __('About us') }}</span></br></br> | ||
| {# We're using dynamic about page links now. If this introduces issues, just uncomment the static ones below and remove the loop. | ||
| <a href="/hvad-er-open-data-dk" class="home-about-links">{{ __('What is Open Data DK?') }}</a></br> | ||
| <a href="/hvad-er-aabne-data" class="home-about-links">{{ __('What is open data?') }}</a></br> | ||
| <a href="/anvend-data" class="home-about-links">{{ __('Apply data') }}</a></br> | ||
| <a href="/udstil-data" class="home-about-links">{{ __('Display data') }}</a></br>#} | ||
| {% for page in aboutPages %} | ||
| {% if loop.index <= 4 %} | ||
| <a href="/{{ page.slug }}" class="home-about-links" aria-label="{{ page.title }}">{{ page.title }}</a><br> | ||
| {% endif %} | ||
| {% endfor %} | ||
| <a href="https://www.was.digst.dk/opendata-dk" class="home-about-links">{{ __('Accessibility statement') }}</a> | ||
| </p> | ||
| </div> | ||
| </div> | ||
|
|
||
| {# Partners section | ||
| <div class="px-gutter md:p-gutter md:w-1/3"> | ||
| <div> | ||
| <p> | ||
|
|
@@ -103,26 +116,27 @@ | |
| </p> | ||
| </div> | ||
| </div> | ||
| #} | ||
|
|
||
| <div class="px-gutter md:p-gutter md:w-1/4"> | ||
| <div> | ||
| <p> | ||
| <span class="home-about-text home-about-text-stacked">{{ __('Contact') }}</span></br></br> | ||
| <a href="mailto:[email protected]" class="home-about-links">[email protected]</a></br> | ||
| {#<a href="https://app.heyloyalty.com/subscribe/10738/3609" class="home-about-links">{{ __('Subscribe to our newsletter') }}</a>#} | ||
| </p> | ||
| <p class="home-about-text-address">OS2 – Offentligt digitaliseringsfællesskab<br>c/o ITK, Aarhus Kommune<br>Hack Kampmanns Plads 2<br>8000 Aarhus C</p> | ||
| {#<a href="https://www.was.digst.dk/opendata-dk" class="home-about-links">{{ __('Availability statement') }}</a>#} | ||
| </div></br> | ||
|
|
||
| {#<ul class="flex"> | ||
| <li> | ||
| <a target="_blank" href="https://www.linkedin.com/company/open-data-dk" class="site-footer_link" aria-label="LinkedIn"> | ||
| <svg class="social-svg" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 448 512"><!--! Font Awesome Pro 6.4.0 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license (Commercial License) Copyright 2023 Fonticons, Inc. --><path d="M416 32H31.9C14.3 32 0 46.5 0 64.3v383.4C0 465.5 14.3 480 31.9 480H416c17.6 0 32-14.5 32-32.3V64.3c0-17.8-14.4-32.3-32-32.3zM135.4 416H69V202.2h66.5V416zm-33.2-243c-21.3 0-38.5-17.3-38.5-38.5S80.9 96 102.2 96c21.2 0 38.5 17.3 38.5 38.5 0 21.3-17.2 38.5-38.5 38.5zm282.1 243h-66.4V312c0-24.8-.5-56.7-34.5-56.7-34.6 0-39.9 27-39.9 54.9V416h-66.4V202.2h63.7v29.2h.9c8.9-16.8 30.6-34.5 62.9-34.5 67.2 0 79.7 44.3 79.7 101.9V416z"/> | ||
| </svg> | ||
| </a> | ||
| </li> | ||
| </ul>#} | ||
|
|
||
| </div> | ||
| </div> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove debug console.log statements before merging.
The diagnostic logging on lines 76-77 appears to be for debugging purposes and should be removed before merging to production to avoid polluting console output.
Apply this diff to remove the debug statements:
if (!res.locals.aboutPages) { res.locals.aboutPages = await getSortedAboutPages(CmsModel); } - for (let page of res.locals.aboutPages) { - console.log("About page:", page.title); - console.log("ORDER:", page.menu_order); - } // Add featured posts📝 Committable suggestion
🤖 Prompt for AI Agents