Skip to content

Add env option for forcing IPv4. #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add env option for forcing IPv4. #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/config/n8n-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { logger } from '../utils/logger';
const n8nApiConfigSchema = z.object({
N8N_API_URL: z.string().url().optional(),
N8N_API_KEY: z.string().min(1).optional(),
N8N_API_FORCE_IPV4: z.coerce.boolean().default(false),
N8N_API_TIMEOUT: z.coerce.number().positive().default(30000),
N8N_API_MAX_RETRIES: z.coerce.number().positive().default(3),
});
Expand Down Expand Up @@ -35,6 +36,7 @@ export function getN8nApiConfig() {
}

return {
ipv4: config.N8N_API_FORCE_IPV4,
baseUrl: config.N8N_API_URL,
apiKey: config.N8N_API_KEY,
timeout: config.N8N_API_TIMEOUT,
Expand Down
16 changes: 14 additions & 2 deletions src/services/n8n-api-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,13 @@ import {
} from '../types/n8n-api';
import { handleN8nApiError, logN8nError } from '../utils/n8n-errors';
import { cleanWorkflowForCreate, cleanWorkflowForUpdate } from './n8n-validation';
import { Agent as HttpsAgent } from 'https';
import { Agent as HttpAgent } from 'http';

export interface N8nApiClientConfig {
baseUrl: string;
apiKey: string;
ipv4: boolean;
timeout?: number;
maxRetries?: number;
}
Expand All @@ -37,14 +40,17 @@ export class N8nApiClient {
private maxRetries: number;

constructor(config: N8nApiClientConfig) {
const { baseUrl, apiKey, timeout = 30000, maxRetries = 3 } = config;
const { baseUrl, apiKey, ipv4, timeout = 30000, maxRetries = 3 } = config;

this.maxRetries = maxRetries;

// Ensure baseUrl ends with /api/v1
const apiUrl = baseUrl.endsWith('/api/v1')
? baseUrl
: `${baseUrl.replace(/\/$/, '')}/api/v1`;

const httpsAgent = new HttpsAgent({ family: 4 });
const httpAgent = new HttpAgent({ family: 4 });

this.client = axios.create({
baseURL: apiUrl,
Expand All @@ -55,13 +61,19 @@ export class N8nApiClient {
},
});

// Request interceptor for logging
// Request interceptor for logging and setting http/s agents.
this.client.interceptors.request.use(
(config: InternalAxiosRequestConfig) => {
logger.debug(`n8n API Request: ${config.method?.toUpperCase()} ${config.url}`, {
params: config.params,
data: config.data,
});

if (ipv4) {
config.httpAgent = httpAgent;
config.httpsAgent = httpsAgent;
}

return config;
},
(error: unknown) => {
Expand Down
Loading