Avoid warning by explicit new dependencies #1766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- base64 will no longer be part of the default gems starting from Ruby 3.4.0 - loggre will no longer be part of the default gems starting from Ruby 3.5.0
luke-hill
reviewed
Nov 11, 2024
Contributor
luke-hill
left a comment
luke-hill
left a comment
There was a problem hiding this comment.
Thanks for this. Couple of minor tweaks.
Note this won't hit until v10 (Next version to be released).
cucumber.gemspec
Outdated
| s.required_ruby_version = '>= 3.0' | ||
| s.required_rubygems_version = '>= 3.2.8' | ||
|
|
||
| s.add_dependency 'base64', '~> 0' |
Contributor
There was a problem hiding this comment.
I'm not a fan of single number relations, because they don't work as advertised. Can we use an x.y reference for these
Co-authored-by: Luke Hill <[email protected]>
luke-hill
approved these changes
Nov 12, 2024
Contributor
|
Thankyou for the contribution |
Contributor
Author
Thank you for your supports and all your contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New explicit dependencies to avoid warnings:
lib/cucumber.rb:7: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
lib/cucumber/formatter/message.rb:4: warning: base64 was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.
Type of change
Please delete options that are not relevant.
work as expected)
Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.
Checklist:
bundle exec rubocopreports no new offenses