Skip to content

feat(client-core): Cache mode for load method #10125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat(client-core): Cache mode for load method #10125

wants to merge 10 commits into from

Conversation

@hannosgit
Copy link
Contributor

@hannosgit hannosgit commented Nov 8, 2025

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Fixes #10107

@hannosgit hannosgit requested a review from a team as a code owner November 8, 2025 09:06
@github-actions github-actions bot added client:core Issues relating to the JavaScript client SDK javascript Pull requests that update Javascript code pr:community Contribution from Cube.js community members. labels Nov 8, 2025
@KSDaemon
Copy link
Member

KSDaemon commented Nov 10, 2025

@hannosgit don't you think it's the same as merged #10091 ?

@hannosgit
Copy link
Contributor Author

hannosgit commented Nov 10, 2025

@hannosgit don't you think it's the same as merged #10091 ?

No #10091 only added the cacheMode to the /cubesql endpoint.
The documentation states that it should also work for the /load endpoint.
However it seems that it does not work in the backend, see #10109 .

@KSDaemon KSDaemon changed the title feat(client-core): cache mode for load method feat(client-core): Cache mode for load method Nov 19, 2025
KSDaemon
KSDaemon reviewed Nov 19, 2025
View reviewed changes
packages/cubejs-client-core/src/types.ts Outdated
timezone?: string;
// @deprecated
renewQuery?: boolean;
cache?: CacheMode;
Copy link
Member

@KSDaemon KSDaemon Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is working from technical perspective, it's incorrect and differs from what is written in the docs. cache options is a part of the REST API POST Request Body or GET Request queryParams, and not a part of the cube query.

Copy link
Contributor Author

@hannosgit hannosgit Nov 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was confused because it was not working and I assumed that the docs are wrong. I fixed it now, can you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KSDaemon KSDaemon KSDaemon left review comments

Assignees

No one assigned

Labels

client:core Issues relating to the JavaScript client SDK javascript Pull requests that update Javascript code pr:community Contribution from Cube.js community members.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(client-core): cache mode for load method

2 participants

@hannosgit @KSDaemon