[TCE] correct css for *-large display sizes #4960
Open
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant GitHub issues?
closes: #4956
related to: #575
What does this pull request do?
There were a couple of images that did not have the correct "large" variant uploaded to the CDN.
This is the same issue described in #575 for the large variants of the "profit", "government", and "property" sections.
Unlike that change though, these panels also require a small css patch to remove the grey bars.
This is the variant used in the CSS rule:1
The updated images that need to be added to the cdn are attached to this PR:
government-large.jpgproperty-large.jpgprofit-large.jpgreconciling-large.jpgHow should this be manually tested?
To test locally:
observe the grey bars by setting the screen dimensions to 1280x800
(DPR 1) in the browser dev tools
put the fixed image in the
website/public/tce/images/directory.apply this patch to load have the local image loaded 0001-TCE-patch-for-testing-css-for-large-display-sizes.patch
reload the page and see the grey bars disappear
Is there any background context you want to provide for reviewers?
before/after screenshots
Acceptance Criteria
These should be checked by the reviewers
Footnotes
There are a few web versions (e.g. czech, polish) that do not
use the templatized version of the TCE, so they are unaffected by this
change ↩
Profit does not have a grey bar initially, however changing the size of the image and the css of the government panel would cause a grey bar if the css for this panel was not also adjusted ↩