-
Notifications
You must be signed in to change notification settings - Fork 428
Pasquale/cui 63 create some table particles #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Pasquale/cui 63 create some table particles #549
Conversation
pasqualevitiello
commented
Dec 3, 2025
- Add full width particle display for larger components like tables
- Improve table and frame components
- Add 2 new table particles
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 20 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/ui/registry/default/particles/p-table-4.tsx">
<violation number="1" location="apps/ui/registry/default/particles/p-table-4.tsx:112">
P2: Interactive `div` with `onKeyDown` handler cannot receive keyboard focus. Add `tabIndex={0}` and `role="button"` to make the sorting functionality keyboard-accessible.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| <div | ||
| className={cn( | ||
| "flex items-center gap-1.5 font-normal tabular-nums", | ||
| isCancelled && "text-muted-foreground line-through opacity-50", | ||
| )} | ||
| > | ||
| <div className={isDelayed ? "text-warning-foreground" : undefined}> | ||
| {row.original.departureTime} | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Interactive div with onKeyDown handler cannot receive keyboard focus. Add tabIndex={0} and role="button" to make the sorting functionality keyboard-accessible.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/ui/registry/default/particles/p-table-4.tsx, line 112:
<comment>Interactive `div` with `onKeyDown` handler cannot receive keyboard focus. Add `tabIndex={0}` and `role="button"` to make the sorting functionality keyboard-accessible.</comment>
<file context>
@@ -0,0 +1,717 @@
+ const isCancelled = row.original.status === "Cancelled";
+ const isDelayed = row.original.status === "Delayed";
+ return (
+ <div
+ className={cn(
+ "flex items-center gap-1.5 font-normal tabular-nums",
</file context>
| <div | |
| className={cn( | |
| "flex items-center gap-1.5 font-normal tabular-nums", | |
| isCancelled && "text-muted-foreground line-through opacity-50", | |
| )} | |
| > | |
| <div className={isDelayed ? "text-warning-foreground" : undefined}> | |
| {row.original.departureTime} | |
| </div> | |
| <div | |
| className="flex h-full cursor-pointer select-none items-center justify-between gap-2" | |
| onClick={header.column.getToggleSortingHandler()} | |
| onKeyDown={(e) => { | |
| if (e.key === "Enter" || e.key === " ") { | |
| e.preventDefault(); | |
| header.column.getToggleSortingHandler()?.(e); | |
| } | |
| }} | |
| role="button" | |
| tabIndex={0} |
✅ Addressed in 00b2581