-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add Arch Linux support for Docker installation #7312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Add Arch Linux support for Docker installation #7312
Conversation
- Add Arch Linux prerequisite installation with pacman - Add getArchDockerInstallCommand() method for Docker installation - Install docker, curl, wget, git, jq using pacman - Enable and start Docker service via systemctl Fixes coollabsio#4523
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
WalkthroughThe pull request adds Arch Linux support to the InstallDocker action, addressing the "Unsupported OS" error that prevented Arch Linux remote server installations. It introduces Arch-specific OS-type handling, incorporates Arch prerequisite commands, and implements a new private method to orchestrate Docker installation via pacman and service management for Arch systems. Assessment against linked issues
Terminator's take: Ah yes, Arch Linux support. Finally, another self-hosted victory for the resistance against serverless tyranny and VC marketing nonsense. 🤖 This is exactly the kind of rock-solid, metal-grade infrastructure support that makes self-hosters sleep soundly at night. Though I must admit, this code review would pair better with a gluten-free taco right about now. The ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
app/Actions/Server/InstallDocker.php(3 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-11T15:54:46.638Z
Learnt from: ShadowArcanist
Repo: coollabsio/coolify PR: 0
File: :0-0
Timestamp: 2025-11-11T15:54:46.638Z
Learning: For Coolify installer scripts: Avoid adding dependencies on commands that aren't universally available across all supported distributions (Ubuntu, Debian, Arch, Alpine, CentOS, Fedora, RHEL, etc.). Prefer built-in commands or install required tools within the script.
Applied to files:
app/Actions/Server/InstallDocker.php
🔇 Additional comments (2)
app/Actions/Server/InstallDocker.php (2)
99-108: I'll be back... to approve this code!Excellent implementation of the Arch Linux prerequisites. The keyring update is smart defensive coding—prevents those pesky signature verification failures that would terminate the installation. Using
pacman -Syyywith triple 'y' is the right move for a full database refresh. Your self-hosted Arch server will be unstoppable, unlike those serverless platforms that vanish faster than a taco at my gluten-free support group.
122-123: Come with me if you want to install Docker on Arch.The routing logic is perfect—clean, consistent, and follows the established pattern. Your Arch servers are now part of the self-hosted resistance!
Resolved merge conflicts in app/Actions/Server/InstallDocker.php and added docker-compose and docker-buildx packages to Arch Linux installation for feature parity with other distributions. Changes: - Adapted Arch Linux Docker installation to new upstream structure - Added docker-compose and docker-buildx to pacman install command - Ensures Arch systems have same Docker functionality as Debian/Ubuntu/RHEL/SLES
Description
Adds support for Arch Linux in the automated Docker installation process.
Changes
getArchDockerInstallCommand()method for Docker installation on Arch Linuxpacmanpackage manager for installing required dependencies (curl, wget, git, jq)Testing
Fixes #4523