enhancement(ci): Add release docker image #844

leojonathanoh · 2023-03-01T09:17:09Z

This adds a multiarch docker image, based on previous work in #245.

Since I'm not an approved collaborator on this repo with read access to repository secrets, the CI will not be able to login to Docker Hub and push images. To show it works, I'm building the same branch on my fork PR to demonstrate that it works. leojonathanoh#1

TODO

Dockerfile to build CNI plugins. Bonus points for playing nice with dependabot.
Multiarch Dockerfile for released "installer" image
Fixup release.sh to use this (or some equivalent)
Build releases automatically via GitHub and push them to ghcr
Cosign all the things! (might need validation)

Implements #806

Signed-off-by: Leonard Jonathan Oh [email protected]

docker-installer/install_cni_plugins.sh

squeed · 2023-03-03T10:24:05Z

.github/workflows/docker.yml

+name: docker
+on:
+  push:
+  # TODO: Build on main?


The question here is, basically, should we build / push on merge? Right?

My first thought is: sure, why not? As long as we aren't bumping the latest tag.

EDIT: yes, this pushes only on main and tags.

.github/workflows/docker.yml

squeed · 2023-03-03T10:25:48Z

This looks awesome! Thanks so much for taking this on!

I have a few small requests, but they're just the cherry on top. If you've got time, that'd be great, but I really want to get this in.

(p.s. this needs a signed-off-by :-) )

squeed · 2023-03-03T10:26:10Z

Also, looks like the new yamllint is mad at something :-p

leojonathanoh · 2023-03-03T11:02:07Z

.github/workflows/docker.yml

+name: docker
+on:
+  push:
+  # TODO: Build on main?


EDIT: yes, this pushes only on main and tags.

.github/workflows/docker.yml

docker-installer/install_cni_plugins.sh

.github/workflows/docker.yml

leojonathanoh · 2023-03-03T16:41:52Z

Do i have to signoff all commits? Or just in the PR body?

squeed · 2023-03-06T16:44:19Z

Do i have to signoff all commits? Or just in the PR body?

All commits :-).

squeed · 2023-03-06T16:44:47Z

But we should squash this down to one or two commits before merging.

s1061123 · 2023-03-06T16:49:41Z

Dockerfile

+
+# This is the final, minimal container
+FROM busybox as final
+COPY docker-installer/install_cni_plugins.sh /script/install_cni_plugins.sh


You may need LABEL command to specify some of label, as github document mentioned, such as org.opencontainers.image.source

As I worked similar stuff in another repo, this org.opencontainers.image.source is required.

Thanks for the tip. Any recommendation on which LABELs to add?

managed to add all the org.opencontainers.image.xxx labels, hope i didn't miss anything.

leojonathanoh · 2023-03-06T19:10:47Z

All commits :-).

But we should squash this down to one or two commits before merging.

will squash it down and sign once the PR is done :)

leojonathanoh · 2023-03-06T19:33:23Z

oh yes, I was wondering about how to tie the release CI process with this docker image's binaries, so there is one source of binaries as discussed in #245 (comment). Can't seem to find out how the release process goes as far as looking around.

leojonathanoh · 2023-03-23T13:28:25Z

squashed my commits down and signed off. i'm not sure what to do with whether previous work should be signed off too?

squeed · 2023-05-09T11:15:43Z

@leojonathanoh can you rebase on main and squash to a single commit please? Then we can get this awesome PR merged!

leojonathanoh · 2023-05-10T08:11:55Z

sure, i'll do this tomorrow when i manage to get some time.

onedr0p · 2023-11-05T14:20:53Z

Any update on this PR @squeed ? Squash and merge and release 🚀

onedr0p · 2023-12-08T19:28:03Z

@leojonathanoh looks like you might need to rebase and fix any conflicts since it's taken this long for a merge :/

leojonathanoh · 2023-12-09T01:55:27Z

Sure 😄

Co-authored-by: Michael Wyraz <[email protected]> Signed-off-by: Leonard Jonathan Oh <[email protected]>

leojonathanoh · 2023-12-12T12:12:55Z

Passed on my fork, see leojonathanoh#1, where I have fork secrets that don't work on the CI here.

Before merging, will need to remove the code marked with TODO in the CI files.

onedr0p · 2024-01-02T14:37:44Z

It's unfortunate that this as been pending so long, it seems like the maintainers are ignoring this or don't find value in this PR 😭

leojonathanoh · 2024-01-03T13:42:23Z

it's fine 😄 perhaps it will get merged. Guess not many in the community need a docker image for updating plugins 😬

MikeZappa87 · 2024-01-08T15:54:39Z

@leojonathanoh hello, sorry things get lost in the shuffle! The best way is to join the weekly sync and put an item on the agenda! Sorry for the delay!

micw · 2024-04-21T11:15:54Z

it's fine 😄 perhaps it will get merged. Guess not many in the community need a docker image for updating plugins 😬

Hello,

I was the author of the initial request (#245). After a few years I'm back to "multus-cni" and had the hope this is meanwhile merged :-(
Just wanted you to know that this is one of the use cases where a docker image of the plugins would be really helpful.

leojonathanoh · 2024-04-21T14:57:05Z

it's fine 😄 perhaps it will get merged. Guess not many in the community need a docker image for updating plugins 😬

Hello,

I was the author of the initial request (#245). After a few years I'm back to "multus-cni" and had the hope this is meanwhile merged :-( Just wanted you to know that this is one of the use cases where a docker image of the plugins would be really helpful.

Thanks for your previous work. Hope to see this merged too 😄

onedr0p · 2024-04-21T15:08:27Z

Elegant996 · 2025-05-20T01:11:49Z

So... what exactly is the holdup on this? It seems like no one wants to review. We get that projects are time consuming, but not providing the means to successfully contribute with this PR while accepting others that also advance the project doesn't sit well...

onedr0p · 2025-05-20T02:44:16Z

They're hoping for people to join their weekly meetings to discuss this. Honestly, I don’t see how a change like this couldn't be handled asynchronously. 🙄

defo89 · 2025-09-23T13:14:15Z

Hello, any chance of this PR to be finally merged?

squeed reviewed Mar 1, 2023

View reviewed changes

docker-installer/install_cni_plugins.sh Outdated Show resolved Hide resolved

squeed reviewed Mar 3, 2023

View reviewed changes

docker-installer/install_cni_plugins.sh Outdated Show resolved Hide resolved

squeed reviewed Mar 3, 2023

View reviewed changes

.github/workflows/docker.yml Outdated Show resolved Hide resolved

leojonathanoh commented Mar 3, 2023

View reviewed changes

leojonathanoh force-pushed the feature/add-release-docker-image branch from 76a6cf4 to 1fa8df7 Compare March 3, 2023 13:44

leojonathanoh commented Mar 3, 2023

View reviewed changes

.github/workflows/docker.yml Show resolved Hide resolved

.github/workflows/docker.yml Show resolved Hide resolved

leojonathanoh force-pushed the feature/add-release-docker-image branch from 3408e60 to 73df0e2 Compare March 3, 2023 19:27

s1061123 reviewed Mar 6, 2023

View reviewed changes

leojonathanoh force-pushed the feature/add-release-docker-image branch from 2c28635 to 9abc4f6 Compare March 23, 2023 13:26

leojonathanoh force-pushed the feature/add-release-docker-image branch from 9abc4f6 to 4772ad7 Compare May 11, 2023 16:27

onedr0p mentioned this pull request Nov 5, 2023

Deprecate cni-plugins container onedr0p/containers#905

Closed

leojonathanoh force-pushed the feature/add-release-docker-image branch from 4772ad7 to 747294f Compare December 9, 2023 10:07

Feature: Add release docker image

04a99b6

Co-authored-by: Michael Wyraz <[email protected]> Signed-off-by: Leonard Jonathan Oh <[email protected]>

leojonathanoh force-pushed the feature/add-release-docker-image branch from b57bc12 to 04a99b6 Compare December 12, 2023 11:56

onedr0p approved these changes Jan 2, 2024

View reviewed changes

onedr0p approved these changes Apr 21, 2024

View reviewed changes

defo89 mentioned this pull request Sep 24, 2025

add Multus CNI gardener/gardener-extension-networking-calico#719

Merged

enhancement(ci): Add release docker image #844

Are you sure you want to change the base?

enhancement(ci): Add release docker image #844

Uh oh!

Conversation

leojonathanoh commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

Uh oh!

Uh oh!

squeed Mar 3, 2023

Choose a reason for hiding this comment

Uh oh!

leojonathanoh Mar 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

squeed commented Mar 3, 2023

Uh oh!

squeed commented Mar 3, 2023

Uh oh!

leojonathanoh Mar 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leojonathanoh commented Mar 3, 2023

Uh oh!

squeed commented Mar 6, 2023

Uh oh!

squeed commented Mar 6, 2023

Uh oh!

s1061123 Mar 6, 2023

Choose a reason for hiding this comment

Uh oh!

leojonathanoh Mar 6, 2023

Choose a reason for hiding this comment

Uh oh!

leojonathanoh Mar 13, 2023

Choose a reason for hiding this comment

Uh oh!

leojonathanoh commented Mar 6, 2023

Uh oh!

leojonathanoh commented Mar 6, 2023

Uh oh!

leojonathanoh commented Mar 23, 2023

Uh oh!

squeed commented May 9, 2023

Uh oh!

leojonathanoh commented May 10, 2023

Uh oh!

onedr0p commented Nov 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

onedr0p commented Dec 8, 2023

Uh oh!

leojonathanoh commented Dec 9, 2023

Uh oh!

leojonathanoh commented Dec 12, 2023

Uh oh!

onedr0p commented Jan 2, 2024

Uh oh!

leojonathanoh commented Jan 3, 2024

Uh oh!

MikeZappa87 commented Jan 8, 2024

Uh oh!

micw commented Apr 21, 2024

Uh oh!

leojonathanoh commented Apr 21, 2024

Uh oh!

onedr0p commented Apr 21, 2024

Uh oh!

Elegant996 commented May 20, 2025

leojonathanoh commented Mar 1, 2023 •

edited

Loading

leojonathanoh Mar 3, 2023 •

edited

Loading

leojonathanoh Mar 3, 2023 •

edited

Loading

onedr0p commented Nov 5, 2023 •

edited

Loading

onedr0p commented May 20, 2025 •

edited

Loading