[NA] [TEST] Refactor delete_all_traces_that_match_name_contains_filter into smaller methods #4182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Breaks down the
delete_all_traces_that_match_name_contains_filtermethod inTracesPageinto targeted helper methods to improve maintainability and uphold the single-responsibility principle, resolving the TODO calling for this refactor.Changes
delete_all_traces_that_match_name_contains_filterinto two private helper methods:_apply_name_contains_filter()for filter setup and_delete_all_filtered_traces()for the deletion loop.Usage
The refactored code maintains the same public interface, so no changes are required in test code:
The method now internally defers to:
_apply_name_contains_filter(name)- Handles filter configuration_delete_all_filtered_traces()- Handles the deletion loop across pagination