Skip to content

Conversation

@RKohler21
Copy link
Contributor

@RKohler21 RKohler21 commented Nov 26, 2025

🗣 Description

This PR addresses an issue in which, when selecting a port in the findings library filter, there would be no indication that a filter had been applied. Now we are able to see a blue dot indicating that the filter is active.

💭 Motivation and context

As a User, I expect the same format to display across the Filter Panel when a filter is selected and being applied to the Search Results page.

🧪 Testing

  1. Log into the CyHy Dashboard
  2. Click Findings Library
  3. Select FILTER under the top banner
  4. Select the Port dropdown arrow and select a port option

Dot reflecting a selection is applied is now displayed

📷 Screenshots (if appropriate)

Screenshot 2025-11-26 at 10 16 05 AM

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.
  • Create a pre-release (necessary if and only if the pre-release version was bumped).

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release (necessary if and only if the version was bumped).

Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to include tests around this functionality? As we move forward coverage will be prioritized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants