Handle formatting output of empty maps and lists #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes carvel-dev#817 Signed-off-by: Ethan Hampton <[email protected]>
Signed-off-by: Ethan Hampton <[email protected]>
Member
|
looks good, but i don't have write access, please ping in carvel slack to get some traction. |
100mik
approved these changes
Aug 4, 2025
100mik
left a comment
100mik
left a comment
There was a problem hiding this comment.
The changes looks good to me! Thanks for the PR.
I would still let @cppforlife tke one final look before merging this away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a special case when a list or map is empty
Fixes #817
Added
0as a non-magic number since a constant would likely make this code, and other code in the repo like it, more confusing. Can revert and add a constant if folks would really prefer.