Skip to content

Conversation

@Saedbhati
Copy link
Collaborator

@Saedbhati Saedbhati commented Nov 17, 2025

Description

Describe your changes in detail (optional if the linked issue already contains a detailed description of the changes).
fixes #3374

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 17, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch unify_summarization

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Review Required PR need to be reviewed label Nov 17, 2025
@Saedbhati Saedbhati marked this pull request as draft November 17, 2025 08:00
@fengju0213 fengju0213 added this to the Sprint 42 milestone Nov 17, 2025
Copy link
Collaborator

@fengju0213 fengju0213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Saedbhati i noticed that the prompt in the toolkit is not yet standardized,when you finish it ,you can reopen the pr

@fengju0213 fengju0213 added Waiting for Update PR has been reviewed, need to be updated based on review comment and removed Review Required PR need to be reviewed labels Nov 18, 2025
@Saedbhati Saedbhati marked this pull request as ready for review November 21, 2025 13:46
@hesamsheikh
Copy link
Collaborator

Hey @Saedbhati

Thanks for the PR. I'm worried this PR doesn't address the core issue that was proposed in #3374 which was unifying the three summarizations under a common backend rather than distributed approaches. I also believe the existing MessageSummarizer class is designed to generate structured JSON summaries of individual messages so adding the assummarize method to it doesn't really align with its purpose. To truly unify, we need a shared backend that all three approaches delegate to (if possible).

Copy link
Collaborator

@hesamsheikh hesamsheikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@Saedbhati Saedbhati marked this pull request as draft November 25, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for Update PR has been reviewed, need to be updated based on review comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhance] Unify Context Summarization Backend

4 participants