Simplify extern definitions for intrinsics #1436
Merged
+123
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deduplicate host panicking shim definitions with the wasm definitions.
alexcrichton
force-pushed
the
deduplicate-extern-definitions
branch
from
f009ee0 to
a765517
Compare
dicej
approved these changes
Nov 25, 2025
| /// This automatically imports when on wasm targets and then defines a dummy | ||
| /// panicking shim for native targets to support native compilation but fail at | ||
| /// runtime. | ||
| macro_rules! extern_wasm { |
Collaborator
There was a problem hiding this comment.
Might want to move this to the crate root and make it public some day since it's generally useful.
Member
Author
There was a problem hiding this comment.
Agreed yeah, it'd be useful even for the generate! macro to use this I think
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
Deduplicate host panicking shim definitions with the wasm definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduplicate host panicking shim definitions with the wasm definitions.