Feature-complete RR #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps get some binaries to test with
Publish dev artifacts from CI
Test out the merge queue
…hooks into a separate module
Things left to complete: * Core wasm support * Improved error handling * Wasmtime CLI integration
… completed core wasm rr
Closed
cfallin
reviewed
Nov 25, 2025
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
This is generally pretty good -- thanks a bunch for all of your hard work here!
I have a ton of nits below but I don't think there is anything fundamentally wrong with any of the design. This is more a lot of polish and getting details right.
My eyes did glaze over at several parts around macro usage, and innards of the component ABI. Definitely will need careful review by Alex and/or others when this lands for real. But this should be a start at least. Happy to discuss any of the below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Func,TypedFunc, andComponentFuncasyncStructure
rrfeature. The only things exposed without the feature arerr::hooks, which offers convenient methods to hook recording/replaying mechanisms into the rest of the engine.As a result,
rrwithouthooksshould be able to land with no impact on existing Wasmtime whatsoever.Observed overheads
Between 4-8%