Skip to content

Fix: Kafka metadata fixes #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Kafka metadata fixes #1261

wants to merge 2 commits into from

Conversation

@prdpx7
Copy link

@prdpx7 prdpx7 commented Dec 25, 2024 •
edited
Loading

This PR fixes the following issues:

  1. Set Kafka's record timestamp as current timestamp
  2. Set ReqID as Kafka's record key instead of empty string

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 25, 2024
@CLAassistant
Copy link

CLAassistant commented Dec 25, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dosubot dosubot bot added the bug Something isn't working label Dec 25, 2024
@prdpx7 prdpx7 changed the title Fix: Set current time instead of epoch 0(1970-01-01T00:00:00) in Kafka message metadata Fix: Set current time instead of epoch -1 in Kafka message metadata Dec 25, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 6, 2025
@prdpx7 prdpx7 changed the title Fix: Set current time instead of epoch -1 in Kafka message metadata Fix: Kafka metadata fixes Jan 6, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prdpx7 @CLAassistant