Skip to content

Conversation

@ematipico
Copy link
Member

Summary

@netlify
Copy link

netlify bot commented Nov 22, 2025

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 2f6bfc7
🔍 Latest deploy log https://app.netlify.com/projects/biomejs/deploys/692ed18eed8c6700084010f9
😎 Deploy Preview https://deploy-preview-3529--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link

coderabbitai bot commented Dec 2, 2025

Walkthrough

Adds a new LocaleNumber Astro component (props: number, approximation) that formats numbers with Intl.NumberFormat and conditionally prefixes ~ when approximation is true. Updates the site footer to include a themed sponsors section with light/dark Depot logos and accompanying CSS. Adds a new blog post (depot-exclusive-sponsor.mdx) with frontmatter, content metrics, and use of LocaleNumber. Edits an existing blog MDX to remove a featured flag and correct dashes/capitalisation. No public API or exported-entity declarations were changed.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description contains only '## Summary' with no actual content, providing no meaningful information about the changeset. Provide a brief description of what the PR accomplishes, even if just a sentence or two about the Depot sponsorship announcement.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: depot blog post' directly corresponds to the main change: a new blog post announcing Depot as Biome's exclusive sponsor.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/depot-platinum-sponsor

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a26dea and 2f6bfc7.

📒 Files selected for processing (2)
  • src/components/LocaleNumber.astro (1 hunks)
  • src/content/docs/blog/depot-exclusive-sponsor.mdx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/LocaleNumber.astro
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: biomejs/website PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-11-28T01:34:31.066Z
Learning: Applies to {astro.config.mjs,lunaria.config.json} : When adding a new locale that doesn't exist in the dashboard, send a PR to update the locales in astro.config.mjs and lunaria.config.json
🪛 LanguageTool
src/content/docs/blog/depot-exclusive-sponsor.mdx

[style] ~19-~19: Consider using a different adjective to strengthen your wording.
Context: ...caleNumber.astro" As for today, we're happy to announce that [Depot](https://depot....

(HAPPY_EXCITED)


[uncategorized] ~23-~23: The preposition ‘of’ seems more likely in this position.
Context: ...ject**, that keeps growing overtime. As for 17th of November (time of writing of th...

(AI_HYDRA_LEO_REPLACE_FOR_OF)


[grammar] ~28-~28: Consider using the plural verb form for the plural noun “numbers”.
Context: ...iome used to use GitHub Action runners. Here's a few numbers: - Linting for pull requ...

(THERE_IS_A_LOT_OF)


[grammar] ~60-~60: Did you mean to write ‘many’ here?
Context: ...n! One reason why we're able to ship so much fixes in every patch release. ### End-...

(SO_MUCH_QUESTIONS)


[uncategorized] ~80-~80: It appears that hyphens are missing in the adjective “up-to-date”.
Context: ...the supported languages and if they are up to date. #### Chat with us Join our [Discord ...

(UP_TO_DATE_HYPHEN)


[uncategorized] ~88-~88: Possible missing preposition found.
Context: ...s, etc., Biome is the project that does for you! There are numerous aspects to exp...

(AI_HYDRA_LEO_MISSING_IT)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Redirect rules - biomejs
  • GitHub Check: Header rules - biomejs
  • GitHub Check: Pages changed - biomejs
  • GitHub Check: test

Comment @coderabbitai help to get the list of available commands and usage tips.

@ematipico ematipico marked this pull request as ready for review December 2, 2025 10:53
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/content/docs/blog/biome-v2-1.mdx (1)

81-113: Tidy up small grammar issues in the closing sections

Two tiny wording fixes to keep the post polished:

-And finally we have also added the related rule
+And finally, we have also added the related rule
-It's still early days in our 2.x journey. Both the scanner are type inference
-are likely to see further improvements. Additionally, our
+It's still early days in our 2.x journey. Both the scanner and the type inference engine
+are likely to see further improvements. Additionally, our
🧹 Nitpick comments (2)
src/components/LocaleNumber.astro (1)

2-15: Make approximation optional with a sane default

Nice tiny utility. To keep call‑sites simple and future‑proof, you could make approximation optional and default it to false when destructuring:

-interface Props {
-	number: number;
-	/**
-	 * When `true`, it prepends `~` to the number.
-	 * */
-	approximation: boolean;
-}
-
-const { number, approximation } = Astro.props;
+interface Props {
+	number: number;
+	/**
+	 * When `true`, it prepends `~` to the number.
+	 */
+	approximation?: boolean;
+}
+
+const { number, approximation = false } = Astro.props;
src/components/starlight/Footer.astro (1)

12-73: Flatten nested .footer-sponsors selectors for safer CSS

The nested .title / .list rules rely on CSS nesting being enabled; flattening them avoids surprises and keeps things explicit:

-	.footer-sponsors {
-		display: flex;
-		flex-direction: column;
-		align-items: center;
-		padding: .5rem 2rem;
-
-		.title {
-			font-weight: bold;
-			margin-bottom: 1rem;
-		}
-
-		.list {
-			display: flex;
-			gap: 1rem;
-		}
-	}
+	.footer-sponsors {
+		display: flex;
+		flex-direction: column;
+		align-items: center;
+		padding: .5rem 2rem;
+	}
+
+	.footer-sponsors .title {
+		font-weight: bold;
+		margin-bottom: 1rem;
+	}
+
+	.footer-sponsors .list {
+		display: flex;
+		gap: 1rem;
+	}
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e62ad7a and b551e2b.

📒 Files selected for processing (4)
  • src/components/LocaleNumber.astro (1 hunks)
  • src/components/starlight/Footer.astro (2 hunks)
  • src/content/docs/blog/biome-v2-1.mdx (2 hunks)
  • src/content/docs/blog/depot-exclusive-sponsor.mdx (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-28T01:34:31.066Z
Learnt from: CR
Repo: biomejs/website PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-11-28T01:34:31.066Z
Learning: Applies to {astro.config.mjs,lunaria.config.json} : When adding a new locale that doesn't exist in the dashboard, send a PR to update the locales in astro.config.mjs and lunaria.config.json

Applied to files:

  • src/components/LocaleNumber.astro
🪛 LanguageTool
src/content/docs/blog/depot-exclusive-sponsor.mdx

[style] ~19-~19: Consider using a different adjective to strengthen your wording.
Context: ...caleNumber.astro" As for today, we're happy to announce that [Depot](https://depot....

(HAPPY_EXCITED)


[uncategorized] ~23-~23: The preposition ‘of’ seems more likely in this position.
Context: ...ject**, that keeps growing overtime. As for 17th of November (time of writing of th...

(AI_HYDRA_LEO_REPLACE_FOR_OF)


[grammar] ~28-~28: Consider using the plural verb form for the plural noun “numbers”.
Context: ...iome used to use GitHub Action runners. Here's a few numbers: - Linting for pull requ...

(THERE_IS_A_LOT_OF)


[style] ~63-~63: As a shorter alternative for ‘able to’, consider using “can”.
Context: ...actice! ### Contributors Contributors are able to see the effect of their PRs way faster ...

(BE_ABLE_TO)


[style] ~63-~63: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ...because the CI is green! One reason why we're able to ship so much fixes in every patch release. ...

(REP_ABLE_TO)


[grammar] ~63-~63: Did you mean to write ‘many’ here?
Context: ...n! One reason why we're able to ship so much fixes in every patch release. ### End-...

(SO_MUCH_QUESTIONS)


[uncategorized] ~83-~83: It appears that hyphens are missing in the adjective “up-to-date”.
Context: ...the supported languages and if they are up to date. #### Chat with us Join our [Discord ...

(UP_TO_DATE_HYPHEN)


[uncategorized] ~91-~91: Possible missing preposition found.
Context: ...s, etc., Biome is the project that does for you! There are numerous aspects to exp...

(AI_HYDRA_LEO_MISSING_IT)

src/content/docs/blog/biome-v2-1.mdx

[typographical] ~81-~81: Consider adding a comma after ‘finally’ for more clarity.
Context: ...y with the progress we are seeing. And finally we have also added the related rule [`n...

(RB_LY_COMMA)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants