-
-
Notifications
You must be signed in to change notification settings - Fork 182
feat: depot blog post #3529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: depot blog post #3529
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: Carson McManus <[email protected]>
Co-authored-by: Carson McManus <[email protected]>
Co-authored-by: The Charmizard <[email protected]>
WalkthroughAdds a new LocaleNumber Astro component (props: Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings🪛 LanguageToolsrc/content/docs/blog/depot-exclusive-sponsor.mdx[style] ~19-~19: Consider using a different adjective to strengthen your wording. (HAPPY_EXCITED) [uncategorized] ~23-~23: The preposition ‘of’ seems more likely in this position. (AI_HYDRA_LEO_REPLACE_FOR_OF) [grammar] ~28-~28: Consider using the plural verb form for the plural noun “numbers”. (THERE_IS_A_LOT_OF) [grammar] ~60-~60: Did you mean to write ‘many’ here? (SO_MUCH_QUESTIONS) [uncategorized] ~80-~80: It appears that hyphens are missing in the adjective “up-to-date”. (UP_TO_DATE_HYPHEN) [uncategorized] ~88-~88: Possible missing preposition found. (AI_HYDRA_LEO_MISSING_IT) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/content/docs/blog/biome-v2-1.mdx (1)
81-113: Tidy up small grammar issues in the closing sectionsTwo tiny wording fixes to keep the post polished:
-And finally we have also added the related rule +And finally, we have also added the related rule-It's still early days in our 2.x journey. Both the scanner are type inference -are likely to see further improvements. Additionally, our +It's still early days in our 2.x journey. Both the scanner and the type inference engine +are likely to see further improvements. Additionally, our
🧹 Nitpick comments (2)
src/components/LocaleNumber.astro (1)
2-15: Makeapproximationoptional with a sane defaultNice tiny utility. To keep call‑sites simple and future‑proof, you could make
approximationoptional and default it tofalsewhen destructuring:-interface Props { - number: number; - /** - * When `true`, it prepends `~` to the number. - * */ - approximation: boolean; -} - -const { number, approximation } = Astro.props; +interface Props { + number: number; + /** + * When `true`, it prepends `~` to the number. + */ + approximation?: boolean; +} + +const { number, approximation = false } = Astro.props;src/components/starlight/Footer.astro (1)
12-73: Flatten nested.footer-sponsorsselectors for safer CSSThe nested
.title/.listrules rely on CSS nesting being enabled; flattening them avoids surprises and keeps things explicit:- .footer-sponsors { - display: flex; - flex-direction: column; - align-items: center; - padding: .5rem 2rem; - - .title { - font-weight: bold; - margin-bottom: 1rem; - } - - .list { - display: flex; - gap: 1rem; - } - } + .footer-sponsors { + display: flex; + flex-direction: column; + align-items: center; + padding: .5rem 2rem; + } + + .footer-sponsors .title { + font-weight: bold; + margin-bottom: 1rem; + } + + .footer-sponsors .list { + display: flex; + gap: 1rem; + }
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/components/LocaleNumber.astro(1 hunks)src/components/starlight/Footer.astro(2 hunks)src/content/docs/blog/biome-v2-1.mdx(2 hunks)src/content/docs/blog/depot-exclusive-sponsor.mdx(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-28T01:34:31.066Z
Learnt from: CR
Repo: biomejs/website PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-11-28T01:34:31.066Z
Learning: Applies to {astro.config.mjs,lunaria.config.json} : When adding a new locale that doesn't exist in the dashboard, send a PR to update the locales in astro.config.mjs and lunaria.config.json
Applied to files:
src/components/LocaleNumber.astro
🪛 LanguageTool
src/content/docs/blog/depot-exclusive-sponsor.mdx
[style] ~19-~19: Consider using a different adjective to strengthen your wording.
Context: ...caleNumber.astro" As for today, we're happy to announce that [Depot](https://depot....
(HAPPY_EXCITED)
[uncategorized] ~23-~23: The preposition ‘of’ seems more likely in this position.
Context: ...ject**, that keeps growing overtime. As for 17th of November (time of writing of th...
(AI_HYDRA_LEO_REPLACE_FOR_OF)
[grammar] ~28-~28: Consider using the plural verb form for the plural noun “numbers”.
Context: ...iome used to use GitHub Action runners. Here's a few numbers: - Linting for pull requ...
(THERE_IS_A_LOT_OF)
[style] ~63-~63: As a shorter alternative for ‘able to’, consider using “can”.
Context: ...actice! ### Contributors Contributors are able to see the effect of their PRs way faster ...
(BE_ABLE_TO)
[style] ~63-~63: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ...because the CI is green! One reason why we're able to ship so much fixes in every patch release. ...
(REP_ABLE_TO)
[grammar] ~63-~63: Did you mean to write ‘many’ here?
Context: ...n! One reason why we're able to ship so much fixes in every patch release. ### End-...
(SO_MUCH_QUESTIONS)
[uncategorized] ~83-~83: It appears that hyphens are missing in the adjective “up-to-date”.
Context: ...the supported languages and if they are up to date. #### Chat with us Join our [Discord ...
(UP_TO_DATE_HYPHEN)
[uncategorized] ~91-~91: Possible missing preposition found.
Context: ...s, etc., Biome is the project that does for you! There are numerous aspects to exp...
(AI_HYDRA_LEO_MISSING_IT)
src/content/docs/blog/biome-v2-1.mdx
[typographical] ~81-~81: Consider adding a comma after ‘finally’ for more clarity.
Context: ...y with the progress we are seeing. And finally we have also added the related rule [`n...
(RB_LY_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
Summary