Skip to content

Conversation

@siketyan
Copy link
Member

@siketyan siketyan commented Jul 5, 2025

biomejs/biome-vscode#686 but for IntelliJ

Added syntax highlighting support for GritQL.

IntelliJ IDEs support TextMate bundles and plugins can provide bundles automatically. By using this, we can rely on the syntax included in the official extension and keep it in sync, instead of having our own PSI implementation.

I also added .grit to the default extensions list that Biome supports format/lint/assist.

image

@siketyan siketyan self-assigned this Jul 5, 2025
@siketyan siketyan requested review from denbezrukov and ematipico July 5, 2025 07:10
@denbezrukov
Copy link
Contributor

I'm wondering if you noticed any missing features in idea textmate support.

Copy link
Contributor

@denbezrukov denbezrukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool!

@siketyan
Copy link
Member Author

siketyan commented Jul 5, 2025

I'm wondering if you noticed any missing features in idea textmate support.

Not yet, but we'll need to have a PSI implementation if we want to do something more than syntax highlighting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a npm package for this feature?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ematipico That's because the IntelliJ TextMate plugin reads package.json to locate the tmLanguage file: https://www.jetbrains.com/help/idea/textmate.html#import-textmate-bundles

@siketyan
Copy link
Member Author

siketyan commented Jul 5, 2025

Pending due to biomejs/biome-vscode#686 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants