-
-
Notifications
You must be signed in to change notification settings - Fork 19
feat: add syntax highlighting for GritQL #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I'm wondering if you noticed any missing features in idea textmate support. |
denbezrukov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool!
Not yet, but we'll need to have a PSI implementation if we want to do something more than syntax highlighting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a npm package for this feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ematipico That's because the IntelliJ TextMate plugin reads package.json to locate the tmLanguage file: https://www.jetbrains.com/help/idea/textmate.html#import-textmate-bundles
|
Pending due to biomejs/biome-vscode#686 (comment) |
biomejs/biome-vscode#686 but for IntelliJ
Added syntax highlighting support for GritQL.
IntelliJ IDEs support TextMate bundles and plugins can provide bundles automatically. By using this, we can rely on the syntax included in the official extension and keep it in sync, instead of having our own PSI implementation.
I also added
.gritto the default extensions list that Biome supports format/lint/assist.