Skip to content

Conversation

@telyn
Copy link
Contributor

@telyn telyn commented Nov 13, 2025

This tag is a non-standard tag used by iTunes, Apple Music, and Swinsian (at least) in preference of the User Frame ALBUMARTISTSORT.

By adding this I'm able to get beets to update the Album Artist Sort in Swinsian.

Thanks to James Bruton who develops Swinsian for the help diagnosing why my fields weren't changing in Swinsian!

I believe this fixes #90.

I've run all the commands listed at the end of CONTRIBUTING.md without any errors raised.

@github-actions
Copy link

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@telyn
Copy link
Contributor Author

telyn commented Nov 13, 2025

Oh, crud, I just saw in #90 that you asked for more references. I planned to provide them because James sent me some documentation from MusicBrainz. I can add this to the commit message if desired too.

Here's the documentation he sent me: https://picard-docs.musicbrainz.org/downloads/MusicBrainz_Picard_Tag_Map.html

As written there, Picard >= 1.2 uses TSO2, while Picard <= 1.1 uses TXXX:ALBUMARTISTSORT

@telyn
Copy link
Contributor Author

telyn commented Nov 13, 2025

Had to add a changelog entry so I took the opportunity to add the documentation link to the commit message :-)

@semohr
Copy link
Contributor

semohr commented Nov 17, 2025

Thanks so much for the contribution. I only just saw this!
We merged a major refactor just now, which shifted some file locations. Would you mind rebasing your PR? The updates should be pretty easy to adjust.

@semohr semohr self-assigned this Nov 17, 2025
@semohr
Copy link
Contributor

semohr commented Nov 23, 2025

@telyn I just tried to push to this branch and apply the changes put it seems like you did not allow maintainers to do that. Would be awesome if you could rebase and reapply the changes.

@telyn
Copy link
Contributor Author

telyn commented Nov 23, 2025

Will do :-) I had no idea such a thing was even possible with GitHub, as I'm quite a casual user of it. But I'll get that rebase done and look into permissions later today. Thanks for looking!

@semohr
Copy link
Contributor

semohr commented Nov 23, 2025

No worries! I think it is a checkbox you can tick if you create the PR. Could also be a permission issue on our side.

@telyn
Copy link
Contributor Author

telyn commented Nov 26, 2025

Heya @semohr - sorry for the wait!

I've rebased to get all the latest changes, and hopefully have a nice clean commit to review :) There's a failing check for documentation format, but when I poe format-docs it's substantially different throughout documentation that I haven't modified or created - don't think it's the place of this PR to modify.

Side note: I have the "Allow edits from Maintainers" enabled on this PR, so I don't know why you couldn't push to my branch :(

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.26%. Comparing base (0a5bd44) to head (988d471).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files          16       16           
  Lines         817      817           
  Branches      118      118           
=======================================
  Hits          762      762           
  Misses         35       35           
  Partials       20       20           

This tag is a non-standard tag used by iTunes, Apple Music, MusicBrainz
Picard, and Swinsian (at least) in preference of the User Frame ALBUMARTISTSORT.

See the Picard Tag Mapping documentation at
https://picard-docs.musicbrainz.org/downloads/MusicBrainz_Picard_Tag_Map.html

By adding this I'm able to get beets to update the Album Artist Sort in
Swinsian.

Thanks to James Bruton who develops Swinsian for the help diagnosing why
my fields weren't changing in Swinsian, and pointing me at the Picard
documentation showing its preference for TSO2.

# Conflicts:
#	docs/changelog.rst
#	mediafile.py
@semohr
Copy link
Contributor

semohr commented Nov 26, 2025

Side note: I have the "Allow edits from Maintainers" enabled on this PR, so I don't know why you couldn't push to my branch :(

Strange, might actually be an issue with my permissions than. I will raise this internally 👍

Edit: Seems like it works now, I'm certain it did not work beforehand!

@semohr
Copy link
Contributor

semohr commented Nov 26, 2025

I've rebased to get all the latest changes, and hopefully have a nice clean commit to review :) There's a failing check for documentation format, but when I poe format-docs it's substantially different throughout documentation that I haven't modified or created - don't think it's the place of this PR to modify.

I just fixed the issue with the #94 PR. It should now only reformat the changelog if you run it.

@telyn
Copy link
Contributor Author

telyn commented Nov 26, 2025

Ah, yeah! It did. The change it suggested didn't match the other changelog entries longer than one line, but I don't mind that if you don't mind that 😛

@semohr semohr merged commit a602f02 into beetbox:master Nov 26, 2025
13 checks passed
@semohr
Copy link
Contributor

semohr commented Nov 26, 2025

Really appreciate your patience on this one! mediafile has been a bit quiet in recent years, but with the modernization work underway, we’re working to get the project active and healthy again.

Thanks for helping move the project forward we are always happy for more contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Itunes ignores albumartist_sort

3 participants