Skip to content

Replace lodash with es-toolkit #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace lodash with es-toolkit #239

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fecb0b6
Replace lodash with es-toolkit
dayongkr Jul 1, 2025
31843c6
move to devDeps
dayongkr Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build2/compat-table
Open in desktop
Submodule compat-table added at fb3c71
6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
"gulp-watch": "^5.0.1",
"jest": "^27.5.1",
"lerna": "^3.22.1",
"lodash": "^4.17.21",
"prettier": "^3.6.2",
"rimraf": "^2.7.1",
"rollup": "^2.79.2",
Expand Down Expand Up @@ -93,5 +92,8 @@
}
},
"version": "0.0.0",
"packageManager": "[email protected]"
"packageManager": "[email protected]",
"dependencies": {
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a devDependency

Copy link
Author

@dayongkr dayongkr Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

"es-toolkit": "^1.39.5"
}
}
2 changes: 1 addition & 1 deletion packages/babel-helper-define-polyfill-provider/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@babel/helper-compilation-targets": "^7.27.2",
"@babel/helper-plugin-utils": "^7.27.1",
"debug": "^4.4.1",
"lodash.debounce": "^4.0.8",
"es-toolkit": "^1.39.5",
"resolve": "^1.22.10"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-helper-define-polyfill-provider/src/node/dependencies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import path from "path";
import debounce from "lodash.debounce";
import debounce from "es-toolkit/compat/debounce";
import requireResolve from "resolve";

const nativeRequireResolve = parseFloat(process.versions.node) >= 8.9;
Expand Down
6 changes: 3 additions & 3 deletions scripts/build-es-shims-data/utils-build-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"use strict";

const fs = require("fs");
const flatMap = require("lodash/flatMap");
const mapValues = require("lodash/mapValues");
const findLastIndex = require("lodash/findLastIndex");
const flatMap = require("es-toolkit/compat/flatMap");
const mapValues = require("es-toolkit/compat/mapValues");
const findLastIndex = require("es-toolkit/compat/findLastIndex");
const electronToChromiumVersions = require("electron-to-chromium").versions;

const envs = require("../../build/compat-table/environments");
Expand Down
28 changes: 20 additions & 8 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/helper-define-polyfill-provider@workspace:^0.6.4, @babel/helper-define-polyfill-provider@workspace:packages/babel-helper-define-polyfill-provider":
"@babel/helper-define-polyfill-provider@workspace:^0.6.5, @babel/helper-define-polyfill-provider@workspace:packages/babel-helper-define-polyfill-provider":
version: 0.0.0-use.local
resolution: "@babel/helper-define-polyfill-provider@workspace:packages/babel-helper-define-polyfill-provider"
dependencies:
Expand All @@ -227,7 +227,7 @@ __metadata:
"@babel/traverse": "npm:^7.27.7"
babel-loader: "npm:^8.4.1"
debug: "npm:^4.4.1"
lodash.debounce: "npm:^4.0.8"
es-toolkit: "npm:^1.39.5"
resolve: "npm:^1.22.10"
rollup: "npm:^2.79.2"
rollup-plugin-babel: "npm:^4.4.0"
Expand Down Expand Up @@ -4506,7 +4506,7 @@ __metadata:
dependencies:
"@babel/compat-data": "npm:^7.27.7"
"@babel/core": "npm:^7.27.7"
"@babel/helper-define-polyfill-provider": "workspace:^0.6.4"
"@babel/helper-define-polyfill-provider": "workspace:^0.6.5"
"@babel/helper-plugin-test-runner": "npm:^7.27.1"
"@babel/plugin-transform-for-of": "npm:^7.27.1"
"@babel/plugin-transform-modules-commonjs": "npm:^7.27.1"
Expand All @@ -4533,7 +4533,7 @@ __metadata:
resolution: "babel-plugin-polyfill-corejs3@workspace:packages/babel-plugin-polyfill-corejs3"
dependencies:
"@babel/core": "npm:^7.27.7"
"@babel/helper-define-polyfill-provider": "workspace:^0.6.4"
"@babel/helper-define-polyfill-provider": "workspace:^0.6.5"
"@babel/helper-plugin-test-runner": "npm:^7.27.1"
"@babel/plugin-proposal-decorators": "npm:^7.27.1"
"@babel/plugin-transform-class-properties": "npm:^7.27.1"
Expand All @@ -4555,7 +4555,7 @@ __metadata:
resolution: "babel-plugin-polyfill-es-shims@workspace:packages/babel-plugin-polyfill-es-shims"
dependencies:
"@babel/core": "npm:^7.27.7"
"@babel/helper-define-polyfill-provider": "workspace:^0.6.4"
"@babel/helper-define-polyfill-provider": "workspace:^0.6.5"
"@babel/helper-plugin-test-runner": "npm:^7.27.1"
array.from: "npm:^1.1.6"
math.clz32: "npm:^1.0.3"
Expand All @@ -4580,7 +4580,7 @@ __metadata:
resolution: "babel-plugin-polyfill-regenerator@workspace:packages/babel-plugin-polyfill-regenerator"
dependencies:
"@babel/core": "npm:^7.27.7"
"@babel/helper-define-polyfill-provider": "workspace:^0.6.4"
"@babel/helper-define-polyfill-provider": "workspace:^0.6.5"
"@babel/helper-plugin-test-runner": "npm:^7.27.1"
"@babel/plugin-transform-regenerator": "npm:~7.14.5"
regenerator-runtime: "npm:^0.14.1"
Expand Down Expand Up @@ -4610,6 +4610,7 @@ __metadata:
babel-jest: "npm:^29.7.0"
chalk: "npm:^3.0.0"
electron-to-chromium: "npm:^1.5.177"
es-toolkit: "npm:^1.39.5"
eslint: "npm:^8.57.1"
eslint-formatter-codeframe: "npm:^7.32.1"
eslint-plugin-import: "npm:^2.32.0"
Expand All @@ -4624,7 +4625,6 @@ __metadata:
gulp-watch: "npm:^5.0.1"
jest: "npm:^27.5.1"
lerna: "npm:^3.22.1"
lodash: "npm:^4.17.21"
prettier: "npm:^3.6.2"
rimraf: "npm:^2.7.1"
rollup: "npm:^2.79.2"
Expand Down Expand Up @@ -6690,6 +6690,18 @@ __metadata:
languageName: node
linkType: hard

"es-toolkit@npm:^1.39.5":
version: 1.39.5
resolution: "es-toolkit@npm:1.39.5"
dependenciesMeta:
"@trivago/[email protected]":
unplugged: true
[email protected]:
unplugged: true
checksum: 10/3b7e7d5bd50b8e603fbde93149d90ae541c1fc804b516d3b22f3d107724fb0b8f91bc4a17ca6af3bd17c8e5be89f1a7ec673a3e7f8a55323704a31e77cc5fa67
languageName: node
linkType: hard

"es5-ext@npm:^0.10.35, es5-ext@npm:^0.10.46, es5-ext@npm:^0.10.50":
version: 0.10.53
resolution: "es5-ext@npm:0.10.53"
Expand Down Expand Up @@ -10739,7 +10751,7 @@ __metadata:
languageName: node
linkType: hard

"lodash@npm:^4.17.12, lodash@npm:^4.17.15, lodash@npm:^4.17.21, lodash@npm:^4.2.1, lodash@npm:^4.7.0":
"lodash@npm:^4.17.12, lodash@npm:^4.17.15, lodash@npm:^4.2.1, lodash@npm:^4.7.0":
version: 4.17.21
resolution: "lodash@npm:4.17.21"
checksum: 10/c08619c038846ea6ac754abd6dd29d2568aa705feb69339e836dfa8d8b09abbb2f859371e86863eda41848221f9af43714491467b5b0299122431e202bb0c532
Expand Down
Loading