Optimize FieldVector conversion to avoid unnecessary container cloning #335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace full container cloning with element-wise iteration in
FieldVector<T>toFieldVector<U>conversion.Problem
The
From<&'a FieldVector<T>> for FieldVector<U>implementation was performing unnecessary full container cloning:This creates an intermediate
Vec<T>allocation before converting elements, causing:Solution
Replace with direct iteration over references with element cloning: