Skip to content

Conversation

@bradwatsonaws
Copy link

@bradwatsonaws bradwatsonaws commented Feb 13, 2025

Issue #, if available:
1536
1482
1823

Description of changes:
Modified all files used for building the AMI to pass in the --no-sign-request flag when pulling files from S3 using the AWS CLI and crossing partitions between GovCloud and Commercial AWS. Wherever the S3 AWS CLI commands are performed, a check is made to see if the AWS_REGION variable contains us-gov and if the BINARY_BUCKET_REGION does not. In these scenarios, the flag will be passed in the request so that the request is not authenticated as crossing partitions will cause the request to fail.

This also required passing in these variables into the hack/latest-binaries.sh script as well as modifying the Makefile to include default values when they are not passed in by the user.

This also resolves a few to-dos mentioned here and here

Note: AS-IS builds in GovCloud have been broken for over a year. A few pull requests have been submitted, but nothing has passed all tests and been merged.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done
Built several different k8s versions of AL2 and AL2023 AMIs across multiple Commercial and GovCloud regions.

See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for 60 days with no activity. Remove the stale label or comment to avoid closure in 14 days

@github-actions github-actions bot added the Stale label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant