feat(neptune-alpha): add publiclyAccessible #36225
Open
+10,137
−3,304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
beginning-contributor
github-actions
bot
added
feature-request
aws-cdk-automation
previously requested changes
Nov 27, 2025
dennis-ruhe-npo
changed the title
aws-cdk-automation
added
the
pr/needs-further-review
dennis-ruhe-npo
force-pushed
the
feature/aws-neptune-alpha-add-publiclyAccessible
branch
from
4305e92 to
e273c48
Compare
This was referenced Nov 27, 2025
…accessible instances
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
phuhung273
reviewed
Dec 2, 2025
| dbInstanceClass: props.instanceType._instanceType, | ||
| dbParameterGroupName: props.parameterGroup?.parameterGroupName, | ||
| autoMinorVersionUpgrade: props.autoMinorVersionUpgrade === true, | ||
| publiclyAccessible: props.publiclyAccessible === true, |
Contributor
There was a problem hiding this comment.
We must use props.publiclyAccessible as not to affect current users, even when they're using default value. Ideally, template should only changes when user explicitly specifies the new param. That's why you see other snapshots also change.
phuhung273
reviewed
Dec 2, 2025
| /** | ||
| * Neptune engine version 1.4.6.2 | ||
| */ | ||
| public static readonly V1_4_6_2 = new EngineVersion('1.4.6.2'); |
Contributor
There was a problem hiding this comment.
I think maintainers would like to see new version in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #35647.
Reason for this change
The
publiclyAccessibleoption allows Neptune instances to be reached from outside a VPC.Description of changes
The changes in this PR add the
publiclyAccessibleoption to the Neptune cluster and instance props.Describe any new or updated permissions being added
None
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license