Skip to content

Conversation

@tstirrat15
Copy link
Contributor

Fixes #2728

Description

See #2728. We want to reserve RESOURCE_EXHAUSTED for things that can be safely retried, and a recursion depth error cannot generally be safely retried. The docs indicate that FAILED_PRECONDITION is more appropriate here.

Changes

  • Change recursion depth error to have a ResourceExhausted code
  • Update tests

Testing

Review.

@tstirrat15 tstirrat15 requested a review from a team as a code owner November 25, 2025 18:38
@github-actions github-actions bot added area/api v1 Affects the v1 API area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) area/dispatch Affects dispatching of requests labels Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.98%. Comparing base (e7390fe) to head (432209c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2729      +/-   ##
==========================================
- Coverage   77.05%   76.98%   -0.06%     
==========================================
  Files         464      464              
  Lines       49188    49188              
==========================================
- Hits        37896    37863      -33     
- Misses       8504     8531      +27     
- Partials     2788     2794       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note this is a breaking change. There are multiple hits in zed referencing this error code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api v1 Affects the v1 API area/dispatch Affects dispatching of requests area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change recursion depth error to FAILED_PRECONDITION

3 participants