Handle CDN invalidations only if CDN explicitly enabled #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DocLM
force-pushed
the
bugfix/cdn-invalidation
branch
from
280a5a5 to
d3116f4
Compare
lpsinger
added a commit
to lpsinger/gcn.nasa.gov
that referenced
this pull request
Dec 6, 2024
Add patch from architect/deploy#389 to prevent Architect from invalidating our CloudFront cache, which would cause performance degradataion for users.
lpsinger
added a commit
to nasa-gcn/gcn.nasa.gov
that referenced
this pull request
Dec 6, 2024
Add patch from architect/deploy#389 to prevent Architect from invalidating our CloudFront cache, which would cause performance degradataion for users.
filmaj
approved these changes
Mar 26, 2025
Member
filmaj
left a comment
filmaj
left a comment
There was a problem hiding this comment.
This looks OK to me but trying to figure out how to get the tests to run...
filmaj
force-pushed
the
bugfix/cdn-invalidation
branch
from
d3116f4 to
6bf982d
Compare
Contributor
|
Any updates on this? |
Member
|
We should add some tests to this PR to enshrine this behaviour; I'm not sure the current state of this repo, there are probably some general updates needed, like node version targeting in github actions and so on. It also seems like many tests are commented out.. when I have a moment this week in the evenings, I'll try to take a look. |
Contributor
|
Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping out! ✨
We really appreciate your commitment to improving Architect
To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:
mainnpm itfrom the repo root)readme.md, help docs, inline docs & comments, etc.)changelog.mdChanges
Hello, I've updated the CDN invalidation code to handle invalidation only if CDN explicitely enabled and managed by Architect.
This should unlock the discussion in architect/architect#1483