Docdb encrypytion in transit #2167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alphadev4
reviewed
Nov 28, 2025
| var helpers = require('../../../helpers/aws'); | ||
|
|
||
| module.exports = { | ||
| title: 'DocumentDB Encryption in Transit', |
Collaborator
There was a problem hiding this comment.
Suggested change
| title: 'DocumentDB Encryption in Transit', | |
| title: 'DocumentDB Encryption In Transit', |
alphadev4
reviewed
Nov 28, 2025
| category: 'DocumentDB', | ||
| domain: 'Databases', | ||
| severity: 'High', | ||
| description: 'Ensure DocumentDB clusters have TLS/SSL encryption in transit enabled.', |
Collaborator
There was a problem hiding this comment.
Suggested change
| description: 'Ensure DocumentDB clusters have TLS/SSL encryption in transit enabled.', | |
| description: 'Ensures that DocumentDB clusters have TLS/SSL encryption in transit enabled.', |
alphadev4
reviewed
Nov 28, 2025
| var resource = cluster.DBClusterArn; | ||
| var tlsEnabled = false; | ||
|
|
||
| if (!cluster.DBClusterParameterGroup) { |
Collaborator
There was a problem hiding this comment.
what unknown results ,it should either pass or fail
HamzaAziz-1
reviewed
Nov 28, 2025
helpers/aws/api_multipart.js
Outdated
| ] | ||
| } | ||
| }, | ||
| describeDBClusterParameters: { |
There was a problem hiding this comment.
Suggested change
| describeDBClusterParameters: { | |
| describeDBClusterParameters: { |
Remove it from here
alphadev4
requested changes
Nov 28, 2025
helpers/aws/api.js
Outdated
| ] | ||
| } | ||
| }, | ||
| describeDBClusterParameters: { |
| recommended_action: 'Modify the cluster parameter group to set the tls parameter to enabled, or create a custom parameter group with TLS enabled and associate it with the cluster.', | ||
| link: 'https://docs.aws.amazon.com/documentdb/latest/developerguide/security.encryption.ssl.html', | ||
| apis: ['DocDB:describeDBClusters', 'DocDB:describeDBClusterParameters'], | ||
| realtime_triggers: ['docdb:ModifyDBCluster', 'docdb:ModifyDBClusterParameterGroup', 'docdb:CreateDBClusterParameterGroup'], |
Collaborator
There was a problem hiding this comment.
Suggested change
| realtime_triggers: ['docdb:ModifyDBCluster', 'docdb:ModifyDBClusterParameterGroup', 'docdb:CreateDBClusterParameterGroup'], | |
| realtime_triggers: [ 'docdb:CreateDBCluster', 'docdb:ModifyDBCluster', 'docdb:ModifyDBClusterParameterGroup', 'docdb:CreateDBClusterParameterGroup','docdb:DeleteDBCluster' ], | |
|
|
||
| if (tlsEnabled) { | ||
| helpers.addResult(results, 0, | ||
| `DocumentDB cluster "${cluster.DBClusterIdentifier}" has TLS encryption in transit enabled`, |
Collaborator
There was a problem hiding this comment.
Suggested change
| `DocumentDB cluster "${cluster.DBClusterIdentifier}" has TLS encryption in transit enabled`, | |
| 'DocumentDB cluster has TLS encryption in transit enabled', |
| region, resource); | ||
| } else { | ||
| helpers.addResult(results, 2, | ||
| `DocumentDB cluster "${cluster.DBClusterIdentifier}" does not have TLS encryption in transit enabled in parameter group "${parameterGroupName}"`, |
Collaborator
There was a problem hiding this comment.
Suggested change
| `DocumentDB cluster "${cluster.DBClusterIdentifier}" does not have TLS encryption in transit enabled in parameter group "${parameterGroupName}"`, | |
| 'DocumentDB cluster does not have TLS encryption in transit enabled in parameter group', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.