THRIFT-5899: Python tests fail for the Appveyor MSVC builds #3229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- See THRIFT-5898
- PR#2929 called out that the changes breaks Python 3.5 since types came in in 3.6 - Python 3.6 errors out with 'from __future__ import annotations' since it looks like it was only added in 3.7
- Getting `raise TApplicationException(TApplicationException.MISSING_RESULT, "testEnum failed: unknown result"` error - PR#2825 state it is a breaking change, not sure why and for what version of Python
- Appveyor error: ` AttributeError: module 'ssl' has no attribute 'PROTOCOL_TLS_CLIENT'`
fishy
approved these changes
Nov 5, 2025
Contributor
Author
|
I have just logged https://issues.apache.org/jira/browse/THRIFT-5900, will try to see if I can do something to get past it without trying to upgrade python. Don't want to now have to mix this PR with also upgrading to Python 3.14 |
fishy
reviewed
Nov 6, 2025
CJCombrink
force-pushed
the
THRIFT-5899_python_appveyor
branch
from
d804449 to
b0e704b
Compare
Contributor
Author
|
@fishy Thanks for your inputs and review, I think I have addressed all feedback. I think we can merge, I propose leaving the |
fishy
approved these changes
Nov 7, 2025
Member
|
@CJCombrink thank you! |
Contributor
Author
|
Given that there is now an expectation for the appveryor builds to pass is there a way to put more strict check on it not getting broken again by PRs to prevent this type of regressions in future? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues as picked up by the MSVC build
Note: The disabling of the shared lib is done due to THRIFT-5898 and should be fixed by #3226 whereby the build will be changed again
[skip ci]anywhere in the commit message to free up build resources.