Fix bugs in AlignByDeviceOrderByLimitOffsetTest#orderByExpressionTest2 due to fixed child-index order #16653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
AlignByDeviceOrderByLimitOffsetTest#orderByExpressionTest2failed non-deterministically under NonDexbecause the test assumed a fixed child-index order in the logical-plan tree.
When the planner inserts or reorders nodes (for example, adding an ExchangeNode before the first TopKNode), the original assertions either threw a
ClassCastExceptionor triggered anAssertionError.Design and Implementation
TopKNode: Added findRootTopK(DistributedQueryPlan), which iterates over every `FragmentInstance and returns the first child that is a TopKNodeassertNotNullfor the root to fail fast if not found.Reproduce the error
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR