IGNITE-27147 Optimise compaction of multiple delta files #7067
+192
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanzlenko
reviewed
Nov 26, 2025
| ByteBuffer buffer = getThreadLocalBuffer(pageSize); | ||
|
|
||
| DeltaFilePageStoreIo[] newerDeltaFiles = filePageStore.getCompletedDeltaFiles() | ||
| .stream().filter(file -> file.fileIndex() > deltaFilePageStore.fileIndex()) |
Contributor
There was a problem hiding this comment.
Suggested change
| .stream().filter(file -> file.fileIndex() > deltaFilePageStore.fileIndex()) | |
| .stream() | |
| .filter(file -> file.fileIndex() > deltaFilePageStore.fileIndex()) |
...ry/src/main/java/org/apache/ignite/internal/pagememory/persistence/compaction/Compactor.java
Show resolved
Hide resolved
| } | ||
|
|
||
| boolean shouldSkip = false; | ||
| for (int i = 0; i < pointers.length; i++) { |
Contributor
There was a problem hiding this comment.
As soon as you'll get rid of pointer array you can replace this loop with foreach loop
Contributor
There was a problem hiding this comment.
Discussed, doesn't take into account loop above
...ry/src/main/java/org/apache/ignite/internal/pagememory/persistence/compaction/Compactor.java
Show resolved
Hide resolved
ivanzlenko
reviewed
Nov 27, 2025
...ry/src/main/java/org/apache/ignite/internal/pagememory/persistence/compaction/Compactor.java
Show resolved
Hide resolved
ivanzlenko
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-27147