FINERACT-2181: Improve validation error messages for interest rate chart slabs in FD and RD products #4793

abhinav-1305 · 2025-06-20T14:10:23Z

Description

Describe the changes made and why they were made.

Implements a fix for FINERACT-2316

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

…art slabs in FD and RD products

adamsaghy · 2025-06-22T20:41:09Z

@abhinav-1305 Please run ./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest to fix checkstyle issues!

bharathcgowda · 2025-06-26T06:02:56Z

@abhinav-1305 did we address the comments raised by @adamsaghy ?

I see 3 checks are still failing, not sure if it is something you need to look into or ignore for this PR

abhinav-1305 · 2025-06-26T06:05:28Z

Hi @bharathcgowda, I haven't looked at it yet. I'll be pushing a fix for the CI failure tonight.

adamsaghy · 2025-07-17T08:31:51Z

@abhinav-1305 What's up here?

adamsaghy · 2025-07-30T15:06:42Z

@abhinav-1305 What's up on this?

adamsaghy · 2025-08-07T08:22:46Z

@abhinav-1305 What's up here?

abhinav-1305 · 2025-08-09T05:13:57Z

Hi @bharathcgowda - 1 test is failing can you look at it?

bharathcgowda · 2025-08-09T14:02:29Z

Hi @adamsaghy, one test case is failing. Could you please help @abhinav-1305 with it?

adamsaghy · 2025-08-10T14:05:47Z

* What went wrong:
Execution failed for task ':fineract-savings:spotlessJavaCheck'.
> The following files had format violations:
      src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChart.java
          @@ -144,14 +144,16 @@
           ························&&·nextSlabs.slabFields().isValidChart(isPrimaryGroupingByAmount))·{
           ····················if·(iSlabs.slabFields().isRateChartOverlapping(nextSlabs.slabFields(),·isPrimaryGroupingByAmount))·{
           ························baseDataValidator.failWithCodeNoParameterAddedToErrorCode("chart.slabs.range.overlapping",
          -································slabContext·+·"·and·"·+·nextSlabContext·+·"There·is·an·overlap·between·these·slabs.·Please·ensure·slabs·do·not·overlap.",
          +································slabContext·+·"·and·"·+·nextSlabContext
          +········································+·"There·is·an·overlap·between·these·slabs.·Please·ensure·slabs·do·not·overlap.",
           ································iSlabs.slabFields().fromPeriod(),·iSlabs.slabFields().toPeriod(),·nextSlabs.slabFields().fromPeriod(),
           ································nextSlabs.slabFields().toPeriod(),·iSlabs.slabFields().getAmountRangeFrom(),
           ································iSlabs.slabFields().getAmountRangeTo(),·nextSlabs.slabFields().getAmountRangeFrom(),
           ································nextSlabs.slabFields().getAmountRangeTo());
           ····················}·else·if·(iSlabs.slabFields().isRateChartHasGap(nextSlabs.slabFields(),·isPrimaryGroupingByAmount))·{
           ························baseDataValidator.failWithCodeNoParameterAddedToErrorCode("chart.slabs.range.has.gap",
          -································slabContext·+·"·and·"·+·nextSlabContext·+·"There·is·a·gap·between·these·slabs.·Please·ensure·slabs·are·continuous.",
          +································slabContext·+·"·and·"·+·nextSlabContext
          +········································+·"There·is·a·gap·between·these·slabs.·Please·ensure·slabs·are·continuous.",
           ································iSlabs.slabFields().fromPeriod(),·iSlabs.slabFields().toPeriod(),·nextSlabs.slabFields().fromPeriod(),
           ································nextSlabs.slabFields().toPeriod(),·iSlabs.slabFields().getAmountRangeFrom(),
           ································iSlabs.slabFields().getAmountRangeTo(),·nextSlabs.slabFields().getAmountRangeFrom(),
          @@ -172,7 +174,8 @@
           ····················}·else·if·(!iSlabs.slabFields().isPeriodsSame(nextSlabs.slabFields()))·{
           ························if·(InterestRateChartSlabFields.isNotProperAmountStart(nextSlabs.slabFields()))·{
           ····························baseDataValidator.failWithCodeNoParameterAddedToErrorCode("chart.slabs.amount.range.start.incorrect",
          -····································nextSlabContext·+·"The·start·amount·of·this·slab·is·incorrect.",·nextSlabs.slabFields().getAmountRangeFrom());
          +····································nextSlabContext·+·"The·start·amount·of·this·slab·is·incorrect.",
          +····································nextSlabs.slabFields().getAmountRangeFrom());
           ························}
           ························if·(iSlabs.slabFields().getAmountRangeTo()·!=·null)·{
           ····························baseDataValidator.failWithCodeNoParameterAddedToErrorCode("chart.slabs.amount.range.end.incorrect",
  Run './gradlew :fineract-savings:spotlessApply' to fix these violations.

Run this:
./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest

bharathcgowda · 2025-08-11T05:51:00Z

@abhinav-1305 can you check @adamsaghy comment please?

IOhacker

I think that the proposed changes for improving the validation will cause difficult to be translated to another language.

adamsaghy · 2025-08-28T08:20:03Z

@abhinav-1305 Would you mind rewrite to use Hibernate Validation messages that got resolved?
You can use: final String interpolatedMessage = messageSource.getMessage(messageKey, null, LocaleContextHolder.getLocale()); to interpolate the message based on the localization.

sidshas03 · 2025-09-16T02:06:59Z

Hi repo authors (@abhinav-1305, @adamsaghy, @bharathcgowda) 👋
I’ve been following PR #4793 for FINERACT-2316 and noticed it’s been open for a while with review feedback. I went through the code and I can take this forward by implementing the parts that are still pending.

https://issues.apache.org/jira/browse/FINERACT-2316

bharathcgowda · 2025-09-16T05:41:27Z

Hi @sidshas03 Thank you for volunteering. Feel free to make the necessary changes

…args); add tests; fix CI - Replace hard-coded error messages with message codes in InterestRateChart.java - Use failWithCode method instead of failWithCodeNoParameterAddedToErrorCode - Add message keys to fineract-provider/src/main/resources/messages.properties - Add German translations in messages_de.properties - Create unit tests for overlap and gap validation error codes and arguments - Update tests to assert both error codes and arguments properly - All quality checks pass (spotless, checkstyle, spotbugs, tests) This supersedes PR apache#4793 and provides proper internationalization support for interest rate chart validation error messages without domain layer coupling.

adamsaghy · 2025-09-23T14:07:43Z

* What went wrong:
Execution failed for task ':fineract-savings:spotlessJavaCheck'.
> The following files had format violations:
      src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChart.java
          @@ -144,14 +144,16 @@
           ························&&·nextSlabs.slabFields().isValidChart(isPrimaryGroupingByAmount))·{
           ····················if·(iSlabs.slabFields().isRateChartOverlapping(nextSlabs.slabFields(),·isPrimaryGroupingByAmount))·{
           ························baseDataValidator.failWithCodeNoParameterAddedToErrorCode("chart.slabs.range.overlapping",
          -································slabContext·+·"·and·"·+·nextSlabContext·+·"There·is·an·overlap·between·these·slabs.·Please·ensure·slabs·do·not·overlap.",
          +································slabContext·+·"·and·"·+·nextSlabContext
          +········································+·"There·is·an·overlap·between·these·slabs.·Please·ensure·slabs·do·not·overlap.",
           ································iSlabs.slabFields().fromPeriod(),·iSlabs.slabFields().toPeriod(),·nextSlabs.slabFields().fromPeriod(),
           ································nextSlabs.slabFields().toPeriod(),·iSlabs.slabFields().getAmountRangeFrom(),
           ································iSlabs.slabFields().getAmountRangeTo(),·nextSlabs.slabFields().getAmountRangeFrom(),
           ································nextSlabs.slabFields().getAmountRangeTo());
           ····················}·else·if·(iSlabs.slabFields().isRateChartHasGap(nextSlabs.slabFields(),·isPrimaryGroupingByAmount))·{
           ························baseDataValidator.failWithCodeNoParameterAddedToErrorCode("chart.slabs.range.has.gap",
          -································slabContext·+·"·and·"·+·nextSlabContext·+·"There·is·a·gap·between·these·slabs.·Please·ensure·slabs·are·continuous.",
          +································slabContext·+·"·and·"·+·nextSlabContext
          +········································+·"There·is·a·gap·between·these·slabs.·Please·ensure·slabs·are·continuous.",
           ································iSlabs.slabFields().fromPeriod(),·iSlabs.slabFields().toPeriod(),·nextSlabs.slabFields().fromPeriod(),
           ································nextSlabs.slabFields().toPeriod(),·iSlabs.slabFields().getAmountRangeFrom(),
           ································iSlabs.slabFields().getAmountRangeTo(),·nextSlabs.slabFields().getAmountRangeFrom(),
          @@ -172,7 +174,8 @@
           ····················}·else·if·(!iSlabs.slabFields().isPeriodsSame(nextSlabs.slabFields()))·{
           ························if·(InterestRateChartSlabFields.isNotProperAmountStart(nextSlabs.slabFields()))·{
           ····························baseDataValidator.failWithCodeNoParameterAddedToErrorCode("chart.slabs.amount.range.start.incorrect",
          -····································nextSlabContext·+·"The·start·amount·of·this·slab·is·incorrect.",·nextSlabs.slabFields().getAmountRangeFrom());
          +····································nextSlabContext·+·"The·start·amount·of·this·slab·is·incorrect.",
          +····································nextSlabs.slabFields().getAmountRangeFrom());
           ························}
           ························if·(iSlabs.slabFields().getAmountRangeTo()·!=·null)·{
           ····························baseDataValidator.failWithCodeNoParameterAddedToErrorCode("chart.slabs.amount.range.end.incorrect",
  Run './gradlew :fineract-savings:spotlessApply' to fix these violations.

bharathcgowda · 2025-10-02T15:05:09Z

@sidshas03 @adamsaghy anything pending to be done on this?

@adamsaghy

- Fix formatting violations in InterestRateChart.java - Addresses Spotless check failures mentioned by @adamsaghy - Resolves CI build issues preventing PR merge Fixes apache#4793

IOhacker · 2025-10-14T15:12:54Z

@abhinav-1305 squash and commit and check the error

…args); add tests; fix CI - Replace hard-coded error messages with message codes in InterestRateChart.java - Use failWithCode method instead of failWithCodeNoParameterAddedToErrorCode - Add message keys to fineract-provider/src/main/resources/messages.properties - Add German translations in messages_de.properties - Create unit tests for overlap and gap validation error codes and arguments - Update tests to assert both error codes and arguments properly - All quality checks pass (spotless, checkstyle, spotbugs, tests) This supersedes PR apache#4793 and provides proper internationalization support for interest rate chart validation error messages without domain layer coupling.

github-actions · 2025-11-14T00:23:24Z

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

adamsaghy · 2025-11-25T12:02:38Z

@abhinav-1305 Please check the failing test case.

FINERACT-2181: Improve validation error messages for interest rate ch…

86b2c93

…art slabs in FD and RD products

abhinav-1305 added 2 commits August 8, 2025 22:14

FINERACT-2181: Refactor validation error messages

fcbd54d

Minor fix

004760a

IOhacker requested changes Aug 22, 2025

View reviewed changes

sidshas03 mentioned this pull request Sep 16, 2025

Fineract 2316 localize interest rate chart validation #5038

Open

github-actions bot added the stale label Nov 14, 2025

adamsaghy closed this Nov 25, 2025

adamsaghy reopened this Nov 25, 2025

github-actions bot removed the stale label Nov 26, 2025

FINERACT-2181: Improve validation error messages for interest rate chart slabs in FD and RD products #4793

Are you sure you want to change the base?

FINERACT-2181: Improve validation error messages for interest rate chart slabs in FD and RD products #4793

Uh oh!

Conversation

abhinav-1305 commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

adamsaghy commented Jun 22, 2025

Uh oh!

bharathcgowda commented Jun 26, 2025

Uh oh!

abhinav-1305 commented Jun 26, 2025

Uh oh!

adamsaghy commented Jul 17, 2025

Uh oh!

adamsaghy commented Jul 30, 2025

Uh oh!

adamsaghy commented Aug 7, 2025

Uh oh!

abhinav-1305 commented Aug 9, 2025

Uh oh!

bharathcgowda commented Aug 9, 2025

Uh oh!

adamsaghy commented Aug 10, 2025

Uh oh!

bharathcgowda commented Aug 11, 2025

Uh oh!

IOhacker left a comment

Choose a reason for hiding this comment

Uh oh!

adamsaghy commented Aug 28, 2025

Uh oh!

sidshas03 commented Sep 16, 2025

Uh oh!

bharathcgowda commented Sep 16, 2025

Uh oh!

adamsaghy commented Sep 23, 2025

Uh oh!

bharathcgowda commented Oct 2, 2025

Uh oh!

IOhacker commented Oct 14, 2025

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

adamsaghy commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

abhinav-1305 commented Jun 20, 2025 •

edited

Loading