Skip to content

Conversation

@snowtimeglass
Copy link
Contributor

Purpose / Description

The "Gallery" icons are inconsistent in the app.
image image

Approach

For the "Gallery" item in Image Occlusion buttons, use the same icon with the "Gallery" icon in the "Attach multimedia content" bottomsheet.

How Has This Been Tested?

image

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@snowtimeglass snowtimeglass marked this pull request as draft November 30, 2025 09:01
@snowtimeglass snowtimeglass force-pushed the use-consistent-icon-for-gallery branch from a6f280f to f26b61c Compare November 30, 2025 09:10
@snowtimeglass snowtimeglass marked this pull request as ready for review November 30, 2025 09:26
@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Dec 1, 2025
@snowtimeglass snowtimeglass force-pushed the use-consistent-icon-for-gallery branch from f26b61c to 6248fe7 Compare December 2, 2025 01:47
@snowtimeglass
Copy link
Contributor Author

I'm sorry. I misunderstood that there was nothing I could do about that lint error. In fact, it was possible to address it.

@david-allison
Copy link
Member

david-allison commented Dec 4, 2025

I don't think this looks good. The icon styles are now inconsistent on the buttons in the Note Editor (filled vs outline).

I think this is better: (image - outlined) - https://fonts.google.com/icons?selected=Material+Symbols+Outlined:image:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=gallery&icon.size=24&icon.color=%23e8eaed

image_24dp_E8EAED_FILL0_wght400_GRAD0_opsz24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Author Reply Waiting for a reply from the original author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants