feat: telemetry reader for IT #965
Conversation
| assertThat(balance2).isEqualTo(110); | ||
| }); | ||
|
|
||
| var steps = telemetryReader.getWorkflowSteps(TransferWorkflow.class, transferId); |
There was a problem hiding this comment.
Different approach, instead of using debugId, I can filter based on the component and id. We still have to send the request with a debug header, but we can hide that fact in our internals.
There was a problem hiding this comment.
Good. Can also use the always debug sampler.
| () -> { | ||
| List<String> workflowSteps = | ||
| telemetryReader.getWorkflowSteps(TransferWorkflow.class, transferId); | ||
| assertThat(workflowSteps).containsOnly("withdraw-step", "deposit-step", "logAndStop"); |
There was a problem hiding this comment.
@pvlugter unfortunately all tracing assertions should be wrapped with Awaitility. Sometimes spans arrive later than the observable outcome, and the assertion fails.
There was a problem hiding this comment.
Yeah, it's often going to need to wait. We could also build in some await expects with timeouts. Like the way that akka testkits work, with expecting messages or stream elements.
aludwiko
force-pushed
the
component-evaluator
branch
from
93d351c to
1b41e46
Compare
|
Ok, ready for review and decision about the feature |
requires: https://github.com/lightbend/akka-runtime/pull/4250/files