Skip to content

Conversation

@jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Nov 18, 2025

Description of Change

Remove the awscli packaging extra.

Assumptions

The discussion around #1424 has not yielded substantial concerns with regards to removing the awscli packaging extra. This PR makes the proposed change concrete and may act as another opportunity for critical discussion or feedback.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): partially addresses Remove awscli and boto3 optional dependencies #1424
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

@jakob-keller jakob-keller added this to the Release 3.0.0 milestone Nov 18, 2025
@jakob-keller jakob-keller added the dependencies Pull requests that update a dependency file label Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.60%. Comparing base (1609736) to head (79c7a9c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1435      +/-   ##
==========================================
- Coverage   91.70%   91.60%   -0.11%     
==========================================
  Files          76       76              
  Lines        8078     8075       -3     
==========================================
- Hits         7408     7397      -11     
- Misses        670      678       +8     
Flag Coverage Δ
no-httpx 88.47% <100.00%> (-0.05%) ⬇️
os-ubuntu-24.04 91.60% <100.00%> (-0.11%) ⬇️
os-ubuntu-24.04-arm 89.60% <100.00%> (-0.11%) ⬇️
python-3.10 89.57% <100.00%> (-0.11%) ⬇️
python-3.11 89.57% <100.00%> (-0.11%) ⬇️
python-3.12 89.57% <100.00%> (-0.11%) ⬇️
python-3.13 89.57% <100.00%> (-0.11%) ⬇️
python-3.14 91.57% <100.00%> (-0.11%) ⬇️
python-3.9 89.59% <100.00%> (-0.11%) ⬇️
unittests 91.60% <100.00%> (-0.11%) ⬇️
with-awscrt 91.24% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakob-keller
Copy link
Collaborator Author

Reviewers: I intend to keep this PR open for a week or so to give everyone the opportunity to chime in.

webknjaz
webknjaz previously approved these changes Nov 18, 2025
@jakob-keller jakob-keller force-pushed the remove-awscli-packaging-extra branch from 699c09b to 79c7a9c Compare November 28, 2025 10:14
@jakob-keller jakob-keller added this pull request to the merge queue Nov 28, 2025
Merged via the queue into aio-libs:master with commit 370462f Nov 28, 2025
23 checks passed
@jakob-keller jakob-keller deleted the remove-awscli-packaging-extra branch November 28, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants