-
Notifications
You must be signed in to change notification settings - Fork 817
Update SapMachine URLs to main #938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Shegox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the original creator of #614 I can confirm that the URL change is intentional and sapmachine.io is as well controlled by the SapMachine team and linked as well on https://github.com/SAP/SAPmachine
|
Hi @skateball, Thanks for this PR! I noticed that only the TypeScript source file (src/distributions/sapmachine/installer.ts) has been updated, but the compiled distribution files are missing. Since GitHub Actions run the pre-built JavaScript directly, you'll need to run the build command and commit the generated files: This will update dist/setup/index.js with your URL changes. Without these compiled files, the action will continue using the old URLs at runtime. |
|
Hi @mahabaleshwars , |
RealCLanger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a small thing that should be corrected.
fcb4621
RealCLanger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
|
Hi @skateball, could you please take a look at the failing checks and resolve the issues? Let me know if you need any help or clarification on the errors. Thank you! |
|
Hi @skateball, thank you for your recent commit. However, I’m still seeing failing checks on this PR. When you have a moment, could you please review the errors and try to resolve them? Thank you for your continued work on this. |
... Test Suites: 1 passed, 1 total Tests: 34 passed, 34 total Snapshots: 0 total Time: 6.411 s, estimated 23 s Ran all test suites matching /sapmachine/i.
|
Hi @skateball, There is a failing check on this PR. To help resolve the build errors, please try the following steps:
In addition, please review the status of any other failing checks shown on this PR and address them as needed to ensure all required checks pass. Once everything is green, we’ll be able to proceed with merging. Let me know if you encounter any issues during these steps or need further assistance! |
|
Hi, I picked this up in #955. @mahabaleshwars, please go there and enable the test run. 😄 @skateball You can close this PR. Cheers |
Description:
The URL to the Version JSON of the available SapMachine releases will change. Therefore we want to update it. Please merge soon.
No documentation and no tests required.
The backport to releases/v4 is #939
Thx&Best Regards
Christian@SapMachine-Team at SAP
Related issue:
#937
Check list: