-
Notifications
You must be signed in to change notification settings - Fork 288
Update to specification from 18ca2533bf18d0458f65e4c9eaead3e586fce25d #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update to specification from 18ca2533bf18d0458f65e4c9eaead3e586fce25d #569
Conversation
Summary of ChangesHello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request brings the A2A protocol specification and its Python implementation up to date with version Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the generated code to align with a new version of the A2A specification. The changes are consistent across all generated files, including protobuf messages, gRPC services, and Pydantic models. Key updates include adding new methods like ListTasks, renaming others for clarity (e.g., TaskSubscription to SubscribeToTask), and marking several fields as required, which enhances data integrity. My only suggestion is to restore the detailed class-level docstrings in src/a2a/grpc/a2a_pb2_grpc.py that were lost during generation, as they provided valuable context for developers. Overall, this is a solid update.
| - TaskPushNotificationConfig are a resource whose parent is a task. | ||
| They have get, list and create methods. | ||
| - AgentCard is a static resource with only a get method. | ||
| """A2AService defines the operations of the A2A protocol. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstrings for A2AServiceStub, A2AServiceServicer (L77), and A2AService (L225) have been significantly shortened, resulting in a loss of valuable information for developers. For example, the previous docstring for A2AServiceStub provided a good overview of the service resources and their methods.
While this is a generated file, I recommend restoring the more detailed docstrings in the source .proto file. This will ensure the generated Python code is well-documented and easier to understand.
Example of lost documentation for A2AServiceStub:
"""A2AService defines the gRPC version of the A2A protocol. This has a slightly
different shape than the JSONRPC version to better conform to AIP-127,
where appropriate. The nouns are AgentCard, Message, Task and
TaskPushNotificationConfig.
- Messages are not a standard resource so there is no get/delete/update/list
interface, only a send and stream custom methods.
- Tasks have a get interface and custom cancel and subscribe methods.
- TaskPushNotificationConfig are a resource whose parent is a task.
They have get, list and create methods.
- AgentCard is a static resource with only a get method.
"""
Commit: a2aproject/A2A@18ca253