Routing: Add boot package #72809
Merged
Routing: Add boot package #72809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +76.4 kB (+3.21%) Total Size: 2.46 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
add/boot-package
branch
from
2de164a to
c51b245
Compare
|
Flaky tests detected in fc9a737. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19027475296
|
ntsekouras
reviewed
Oct 30, 2025
| { | ||
| selector: | ||
| 'ImportDeclaration[source.value=/^@wordpress\\u002F.+\\u002F/]', | ||
| 'ImportDeclaration[source.value=/^@wordpress\\u002F.+\\u002F/]:not([source.value=/^@wordpress\\u002F.+\\u002Fbuild-types\\u002F/])', |
Contributor
There was a problem hiding this comment.
Why make this change? Isn't any other way of importing types from a package?
Contributor
Author
There was a problem hiding this comment.
Right now no, third-party devs have been doing this forever. The other way is to export all types from the "index" of components which is being explored in its own PR. #72831
ntsekouras
reviewed
Oct 31, 2025
ntsekouras
reviewed
Oct 31, 2025
ntsekouras
reviewed
Oct 31, 2025
|
|
||
| export default function Root() { | ||
| return ( | ||
| <ThemeProvider isRoot color={ { bg: '#f8f8f8', primary: '#3858e9' } }> |
Contributor
There was a problem hiding this comment.
Should we pass scheme to the provider instead of bg and primary?
Contributor
Author
There was a problem hiding this comment.
It doesn't work for me with scheme, accent, it only works with bg, primary. cc @aduth might enlighten us.
Member
There was a problem hiding this comment.
scheme is outdated from earlier iterations of the theme provider implementation which explored configurable light and dark modes, but light and dark is handled internally by the color ramp algorithm in the implementation that was merged.
This should be updated in the documentation. I've created an issue at #72932
ntsekouras
reviewed
Oct 31, 2025
ntsekouras
reviewed
Oct 31, 2025
ntsekouras
reviewed
Oct 31, 2025
| "exports": { | ||
| ".": { | ||
| "types": "./build-types/index.d.ts", | ||
| "types": "./build-types", |
Contributor
There was a problem hiding this comment.
Do you think this change should be part of this PR?
Contributor
Author
There was a problem hiding this comment.
It is mandatory otherwise I can't use the types from this package. (Unless we land the alternative PR first)
Member
There was a problem hiding this comment.
@youknowriad Can you elaborate what's mandatory about this? I ran into the opposite issue in #72978 with the changes here causing resolution to fail.
Contributor
Author
There was a problem hiding this comment.
These two imports fail otherwise
Member
There was a problem hiding this comment.
To me, that's expected for those kind of imports to fail. If we want to expose the types, they should be exported from the index. Otherwise we're kinda defeating part of the point of exports.
Member
There was a problem hiding this comment.
And I don't know that we do want those types to be exported. For those, we could probably be using React.ComponentTypes (related blog post)?
Contributor
Author
There was a problem hiding this comment.
No disagreement, it's what the alternative PR is trying to do #72831
The change here just brings things back to what it used to be pre-build v2 but I don't mind moving towards exporting all the types needed explicitly.
ntsekouras
reviewed
Oct 31, 2025
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
Thanks Riad! This is a great starting point for the new admin pages. I think there might be a few things that are not needed right now, but I know you're going to follow up with more changes and didn't want to have an even bigger PR.
My comments are very small and we want 🟢 CI and we can land.
youknowriad
requested review from
fabiankaegy and
juanmaguitar
as code owners
youknowriad
force-pushed
the
add/boot-package
branch
from
f6fd476 to
fc9a737
Compare
ntsekouras
approved these changes
Nov 3, 2025
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
I think it's okay to land and iterate. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #70862
What?
As shared on the issue, this PR starts by introducing a new @wordpress/boot package - a minimal framework inspired by the site editor, providing a foundation for building modern WordPress admin pages with client-side routing. The ultimate goal is to refactor the site editor with it to allow third-party extensibility.
The boot package provides:
It is very early to judge this though, we need to work on routes, lazy loading and more. This is just the initial brick. It includes a sidebar with some example menu items and single hello world static route.
I have some accompanying PHP to code to allow testing this by navigating to this url
wp-admin/admin.php?page=gutenberg-boot. The goal for this PHP code is to be auto-generated by the build tool.Testing Instructions
- Site icon and title display immediately
- Dark sidebar with light content area
- Command palette opens with Cmd+K