Fix armstrong number implementation #7097
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duvvuvenkataramana
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7097 +/- ##
============================================
+ Coverage 78.50% 78.52% +0.01%
- Complexity 6752 6756 +4
============================================
Files 759 760 +1
Lines 22402 22413 +11
Branches 4400 4402 +2
============================================
+ Hits 17587 17600 +13
+ Misses 4109 4108 -1
+ Partials 706 705 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Implemented ArmstrongNumber.isArmstrong() method - Added comprehensive unit tests for Armstrong numbers - Includes documentation with examples - Handles edge cases (negative numbers, zero) - Tests cover known Armstrong numbers: 0, 1, 153, 370, 371, 407, 1634 Signed-off-by: duvvuvenkataramana <[email protected]>
- Added explicit cast from double to int for Math.pow result - Resolves 'implicit cast is possibly lossy' compiler warning - Project uses -Werror flag which treats warnings as errors Signed-off-by: duvvuvenkataramana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java