Skip to content

JACOCO-63 Update plugin QA matrix with supported versions of SQS #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

JACOCO-63 Update plugin QA matrix with supported versions of SQS #136

wants to merge 10 commits into from
+5 −5

Conversation

@dorian-burihabwa-sonarsource
Copy link
Contributor

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource commented Oct 27, 2025 •
edited by atlassian bot
Loading

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource changed the title JACOCO-63 Update plugin QA matrix with supported version of SQS JACOCO-63 Update plugin QA matrix with supported versions of SQS Oct 27, 2025
@sonarqube-next
Copy link

sonarqube-next bot commented Oct 27, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next
Copy link

sonarqube-next bot commented Nov 11, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next
Copy link

sonarqube-next bot commented Nov 21, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource marked this pull request as ready for review November 21, 2025 16:29
GabrielFleischer
GabrielFleischer requested changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@GabrielFleischer GabrielFleischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixed version is definitely a great addition.

I am not sure about the downgrade of the sonar-java / sonar-kotlin versions. Could you confirm ?

its/src/test/java/org/sonar/plugins/jacoco/its/JacocoTest.java
Comment on lines -67 to -68
builder.addPlugin(URLLocation.create(new URL("https://binaries.sonarsource.com/Distribution/sonar-java-plugin/sonar-java-plugin-8.19.0.40387.jar")));
builder.addPlugin(URLLocation.create(new URL("https://binaries.sonarsource.com/Distribution/sonar-kotlin-plugin/sonar-kotlin-plugin-3.3.0.7402.jar")));
Copy link
Contributor

@GabrielFleischer GabrielFleischer Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this version rollback voluntary ?

Copy link
Contributor Author

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lowered the version (it is not a rollback to the version you changed recently but something a little more recent)
I wanted to make sure that we were using plugins that are meant to be compatible with the oldest version of the two, which would be 2025.1.
Would it help if added a comment so explain why these 2 versions were picked? Or would you prefer I roll back to the value on master?

Copy link
Contributor

@GabrielFleischer GabrielFleischer Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, ok it makes sense.

Thanks for confirming.

GabrielFleischer
GabrielFleischer approved these changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@GabrielFleischer GabrielFleischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add a comment if you want, I don't think it's absolutely necessary.

its/src/test/java/org/sonar/plugins/jacoco/its/JacocoTest.java
Comment on lines -67 to -68
builder.addPlugin(URLLocation.create(new URL("https://binaries.sonarsource.com/Distribution/sonar-java-plugin/sonar-java-plugin-8.19.0.40387.jar")));
builder.addPlugin(URLLocation.create(new URL("https://binaries.sonarsource.com/Distribution/sonar-kotlin-plugin/sonar-kotlin-plugin-3.3.0.7402.jar")));
Copy link
Contributor

@GabrielFleischer GabrielFleischer Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, ok it makes sense.

Thanks for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GabrielFleischer GabrielFleischer GabrielFleischer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dorian-burihabwa-sonarsource @GabrielFleischer