Skip to content

Conversation

@sonbua
Copy link

@sonbua sonbua commented Aug 8, 2023

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Add backported fix for #2243
Relates to #2245

@CLAassistant
Copy link

CLAassistant commented Aug 8, 2023

CLA assistant check
All committers have signed the CLA.

@sonbua sonbua changed the title V2 backport: 2243 V2 backport: 2243 - Ignore unknown chunks for WEBP Aug 14, 2023
@sonbua
Copy link
Author

sonbua commented Aug 14, 2023

Would someone help to review @JimBobSquarePants @brianpopow? This basically backports PR #2245, ignore unknown chunks for WEBP, to v2.

@JimBobSquarePants
Copy link
Member

We don't normally backport fixes into legacy versions unless there are specific security reasons. Users are encouraged to upgrade to the latest released version.

@sonbua
Copy link
Author

sonbua commented Aug 14, 2023

This could be closed then.

@sonbua sonbua closed this Aug 14, 2023
@a-stankevich
Copy link

We have to stick with v2 thanks to its support of older .net versions. And v2 keeps crashing more and more these days on webp files because of this header issue.

Any chance to reconsider this issue for backporting to v2 for those who can't afford upgrading to v3 yet?

Thank you

@JimBobSquarePants JimBobSquarePants merged commit 2c3967b into SixLabors:release/2.1.x Nov 25, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants