-
Notifications
You must be signed in to change notification settings - Fork 17
[SPH] Add substepping #1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[SPH] Add substepping #1320
Conversation
| Tscal time = 0; ///< Current time | ||
| Tscal dt_sph = 0; ///< Current time step | ||
| Tscal dt_force = 0; ///< Current force time step |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Tscal time = 0; ///< Current time | |
| Tscal dt_sph = 0; ///< Current time step | |
| Tscal dt_force = 0; ///< Current force time step | |
| Tscal time = 0; ///< Current time | |
| Tscal dt_sph = 0; ///< Current time step | |
| std::optional<Tscal> dt_force = std::nullopt; ///< Current force time step |
We could make it optional such that it is not used if the substepping is off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be once the substring routine is integrated in the main evolve algorithm, for now it's in a separate function (evolve_once_substep) for testing purposes and to not affect the rest of the code.
Workflow reportworkflow report corresponding to commit 2c6afe5 Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportNo relevant changes found. You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review. Doxygen diff with
|
Following the 1992 Tuckerman algorithm.