Skip to content

Conversation

@y-lapeyre
Copy link
Collaborator

Following the 1992 Tuckerman algorithm.

Comment on lines +193 to +195
Tscal time = 0; ///< Current time
Tscal dt_sph = 0; ///< Current time step
Tscal dt_force = 0; ///< Current force time step
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Tscal time = 0; ///< Current time
Tscal dt_sph = 0; ///< Current time step
Tscal dt_force = 0; ///< Current force time step
Tscal time = 0; ///< Current time
Tscal dt_sph = 0; ///< Current time step
std::optional<Tscal> dt_force = std::nullopt; ///< Current force time step

We could make it optional such that it is not used if the substepping is off

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be once the substring routine is integrated in the main evolve algorithm, for now it's in a separate function (evolve_once_substep) for testing purposes and to not affect the rest of the code.

@tdavidcl tdavidcl added the draft label Oct 31, 2025
@github-actions
Copy link

Workflow report

workflow report corresponding to commit 2c6afe5
Commiter email is [email protected]
GitHub page artifact URL GitHub page artifact link (can expire)

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
ruff check...............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 59
New warnings : 66
Warnings count : 7134 → 7141 (0.1%)

Detailed changes :
+ src/shammodels/sph/include/shammodels/sph/Model.hpp:907: warning: Member evolve_once_substep() (function) of class shammodels::sph::Model is not documented.
- src/shammodels/sph/include/shammodels/sph/Model.hpp:907: warning: Member evolve_until(Tscal target_time, i32 niter_max) (function) of class shammodels::sph::Model is not documented.
+ src/shammodels/sph/include/shammodels/sph/Model.hpp:912: warning: Member evolve_until(Tscal target_time, i32 niter_max) (function) of class shammodels::sph::Model is not documented.
+ src/shammodels/sph/include/shammodels/sph/Model.hpp:916: warning: Member evolve_until_substep(Tscal target_time, i32 niter_max) (function) of class shammodels::sph::Model is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:146: warning: Member do_predictor_substep(Tscal dt_sph) (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:147: warning: Member update_artificial_viscosity(Tscal dt) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:148: warning: Member do_substep() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:149: warning: Member init_ghost_layout() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:150: warning: Member update_artificial_viscosity(Tscal dt) (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:151: warning: Member communicate_merge_ghosts_fields() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:152: warning: Member init_ghost_layout() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:152: warning: Member reset_merge_ghosts_fields() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:154: warning: Member communicate_merge_ghosts_fields() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:154: warning: Member compute_eos_fields() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:155: warning: Member reset_eos_fields() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:155: warning: Member reset_merge_ghosts_fields() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:157: warning: Member compute_eos_fields() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:157: warning: Member prepare_corrector() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:158: warning: Member reset_eos_fields() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:158: warning: Member update_derivs() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:160: warning: Member prepare_corrector() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:161: warning: Member update_derivs() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:162: warning: Member update_derivs_substep() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:167: warning: Member update_sync_load_values() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:169: warning: Member Solver(ShamrockCtx &context) (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:171: warning: Member init_solver_graph() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:171: warning: Member update_sync_load_values() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:172: warning: Member part_killing_step() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:173: warning: Member Solver(ShamrockCtx &context) (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:174: warning: Member vtk_do_dump(std::string filename, bool add_patch_world_id) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:175: warning: Member init_solver_graph() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:176: warning: Member part_killing_step() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:176: warning: Member set_debug_dump(bool _do_debug_dump, std::string _debug_dump_filename) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:178: warning: Member vtk_do_dump(std::string filename, bool add_patch_world_id) (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:180: warning: Member print_timestep_logs() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:180: warning: Member set_debug_dump(bool _do_debug_dump, std::string _debug_dump_filename) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:184: warning: Member print_timestep_logs() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:187: warning: Member evolve_once() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:189: warning: Member evolve_once_time_expl(Tscal t_current, Tscal dt_input) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:191: warning: Member evolve_once() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:192: warning: Member evolve_once_substep() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:194: warning: Member evolve_once_time_expl(Tscal t_current, Tscal dt_input) (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:196: warning: Member evolve_until(Tscal target_time, i32 niter_max) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:201: warning: Member evolve_until(Tscal target_time, i32 niter_max) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:234: warning: Member evolve_until_substep(Tscal target_time, i32 niter_max) (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:211: warning: Member RTree (typedef) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:214: warning: Member RTree (typedef) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:219: warning: Member track_particles_id (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:221: warning: Member set_particle_tracking(bool state) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:222: warning: Member track_particles_id (variable) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:224: warning: Member set_particle_tracking(bool state) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:274: warning: Member particle_killing (variable) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:277: warning: Member particle_killing (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:324: warning: Member MHDConfig (typedef) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:325: warning: Member mhd_config (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:338: warning: Member set_NonIdealMHD(typename MHDConfig::NonIdealMHD v) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:340: warning: Member MHDConfig (typedef) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:341: warning: Member mhd_config (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:348: warning: Member DustConfig (typedef) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:349: warning: Member dust_config (variable) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:354: warning: Member set_NonIdealMHD(typename MHDConfig::NonIdealMHD v) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:364: warning: Member DustConfig (typedef) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:365: warning: Member dust_config (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:367: warning: Member show_neigh_stats (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:368: warning: Member set_show_neigh_stats(bool enable) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:383: warning: Member show_neigh_stats (variable) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:384: warning: Member set_show_neigh_stats(bool enable) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:387: warning: Member smoothing_length_config (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:389: warning: Member set_smoothing_length_density_based() (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:392: warning: Member set_smoothing_length_density_based_neigh_lim(u32 max_neigh_count) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:396: warning: Member enable_particle_reordering (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:397: warning: Member set_enable_particle_reordering(bool enable) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:398: warning: Member particle_reordering_step_freq (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:399: warning: Member set_particle_reordering_step_freq(u64 freq) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:403: warning: Member smoothing_length_config (variable) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:405: warning: Member set_smoothing_length_density_based() (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:408: warning: Member set_smoothing_length_density_based_neigh_lim(u32 max_neigh_count) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:412: warning: Member enable_particle_reordering (variable) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:413: warning: Member set_enable_particle_reordering(bool enable) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:414: warning: Member particle_reordering_step_freq (variable) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:415: warning: Member set_particle_reordering_step_freq(u64 freq) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:473: warning: The following parameter of shammodels::sph::SolverConfig::set_eos_locally_isothermalFA2014(Tscal h_over_r) is not documented:
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:473: warning: argument 'cs0' of command @param is not found in the argument list of shammodels::sph::SolverConfig< Tvec, SPHKernel >::set_eos_locally_isothermalFA2014(Tscal h_over_r)
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:473: warning: argument 'q' of command @param is not found in the argument list of shammodels::sph::SolverConfig< Tvec, SPHKernel >::set_eos_locally_isothermalFA2014(Tscal h_over_r)
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:473: warning: argument 'r0' of command @param is not found in the argument list of shammodels::sph::SolverConfig< Tvec, SPHKernel >::set_eos_locally_isothermalFA2014(Tscal h_over_r)
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:489: warning: The following parameter of shammodels::sph::SolverConfig::set_eos_locally_isothermalFA2014(Tscal h_over_r) is not documented:
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:489: warning: argument 'cs0' of command @param is not found in the argument list of shammodels::sph::SolverConfig< Tvec, SPHKernel >::set_eos_locally_isothermalFA2014(Tscal h_over_r)
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:489: warning: argument 'q' of command @param is not found in the argument list of shammodels::sph::SolverConfig< Tvec, SPHKernel >::set_eos_locally_isothermalFA2014(Tscal h_over_r)
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:489: warning: argument 'r0' of command @param is not found in the argument list of shammodels::sph::SolverConfig< Tvec, SPHKernel >::set_eos_locally_isothermalFA2014(Tscal h_over_r)
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:741: warning: Member check_config() (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:757: warning: Member check_config() (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:758: warning: Member set_layout(shamrock::patch::PatchDataLayerLayout &pdl) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:759: warning: Member set_ghost_layout(shamrock::patch::PatchDataLayerLayout &ghost_layout) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:774: warning: Member set_layout(shamrock::patch::PatchDataLayerLayout &pdl) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:775: warning: Member set_ghost_layout(shamrock::patch::PatchDataLayerLayout &ghost_layout) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:828: warning: Member to_json(nlohmann::json &j, const ParticleKillingConfig< Tvec > &p) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:828: warning: Member to_json(nlohmann::json &j, const ParticleKillingConfig< Tvec > &p) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:841: warning: Member from_json(const nlohmann::json &j, ParticleKillingConfig< Tvec > &p) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:841: warning: Member from_json(const nlohmann::json &j, ParticleKillingConfig< Tvec > &p) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:844: warning: Member to_json(nlohmann::json &j, const ParticleKillingConfig< Tvec > &p) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:844: warning: Member to_json(nlohmann::json &j, const ParticleKillingConfig< Tvec > &p) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:856: warning: Member to_json(nlohmann::json &j, const SmoothingLengthConfig &p) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:856: warning: Member to_json(nlohmann::json &j, const SmoothingLengthConfig &p) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:857: warning: Member from_json(const nlohmann::json &j, ParticleKillingConfig< Tvec > &p) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:857: warning: Member from_json(const nlohmann::json &j, ParticleKillingConfig< Tvec > &p) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:872: warning: Member to_json(nlohmann::json &j, const SmoothingLengthConfig &p) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:872: warning: Member to_json(nlohmann::json &j, const SmoothingLengthConfig &p) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:876: warning: Member from_json(const nlohmann::json &j, SmoothingLengthConfig &p) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:876: warning: Member from_json(const nlohmann::json &j, SmoothingLengthConfig &p) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:892: warning: Member from_json(const nlohmann::json &j, SmoothingLengthConfig &p) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:892: warning: Member from_json(const nlohmann::json &j, SmoothingLengthConfig &p) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1003: warning: Member register_analysis_impl_for_each_kernel(py::module &msph, const char *name_class) (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1055: warning: Member Register_pymod(pysphmodel) (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1064: warning: Member Register_pymod(pysphmodel) (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:921: warning: Member add_analysisBarycenter_instance(py::module &m, std::string name_model) (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:930: warning: Member add_analysisBarycenter_instance(py::module &m, std::string name_model) (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:939: warning: Member add_analysisEnergyKinetic_instance(py::module &m, std::string name_model) (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:948: warning: Member add_analysisEnergyKinetic_instance(py::module &m, std::string name_model) (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:955: warning: Member add_analysisEnergyPotential_instance(py::module &m, std::string name_model) (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:964: warning: Member add_analysisEnergyPotential_instance(py::module &m, std::string name_model) (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:971: warning: Member add_analysisTotalMomentum_instance(py::module &m, std::string name_model) (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:980: warning: Member add_analysisTotalMomentum_instance(py::module &m, std::string name_model) (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:989: warning: Member analysis_impl(shammodels::sph::Model< Tvec, SPHKernel > &model) -> Analysis (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:994: warning: Member register_analysis_impl_for_each_kernel(py::module &msph, const char *name_class) (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:998: warning: Member analysis_impl(shammodels::sph::Model< Tvec, SPHKernel > &model) -> Analysis (function) of file pySPHModel.cpp is not documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants