Skip to content

Conversation

@o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Sep 19, 2025

Description

  1. Set VSCode settings.json to not create .sln project file automatically.
    {
        "dotnet.automaticallyCreateSolutionInWorkspace": false
    }
  2. Fix reference to PSScriptAnalyzer settings file, which is located one dir up from VSCode settings.json.
  3. Add format on save for PowerShell files "[powershell]": {"editor.formatOnSave": true} for consistency, else why specify formatting settings in .vscode/settings.json?
  4. Add "files.insertFinalNewline": true, because EditorConfig did not seem to apply that consistently.

Motivation and Context

Closes #6492

How Has This Been Tested?

It's just a small VSCode settings change.

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.
    • This does not change anything in Scoop?

Summary by CodeRabbit

  • Chores
    • Updated editor workspace settings for code analysis and formatting.
    • Consolidated analyzer configuration into a dedicated settings block.
    • Changed workspace behavior to stop automatic .NET solution file creation.
    • Preserved and reorganized file exclusion rules for consistency.
    • No user-facing functionality or UI changes.

@coderabbitai
Copy link

coderabbitai bot commented Oct 13, 2025

Walkthrough

Updates to .vscode/settings.json reorganize PowerShell/PSScriptAnalyzer and formatting settings into a new block referencing ../PSScriptAnalyzerSettings.psd1, add per-language format-on-save and final newline insertion, retain/update files.exclude, and set dotnet.automaticallyCreateSolutionInWorkspace to false.

Changes

Cohort / File(s) Summary
Editor config — VSCode settings
.vscode/settings.json
- Moved PSScriptAnalyzer settings to use ../PSScriptAnalyzerSettings.psd1 and restored related PowerShell formatting options (including [powershell].editor.formatOnSave: true)
- Added dotnet.automaticallyCreateSolutionInWorkspace: false
- Added files.insertFinalNewline: true and preserved/adjusted files.exclude entries

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I hop through settings, tidy and light,
No stray .sln in my burrow tonight.
Scripts check from a psd1 so near,
Format-on-save keeps the lines clear.
🐇🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Out of Scope Changes Check ⚠️ Warning The pull request introduces several additional VSCode configuration changes—such as per‐language PowerShell formatting, files.exclude restructuring, final newline insertion, and relocation of the PSScriptAnalyzer settings path—that are unrelated to disabling automatic .sln creation per issue #6492. These extra modifications fall outside the scope of the linked issue and may complicate review. Please restrict this PR to the "dotnet.automaticallyCreateSolutionInWorkspace": false change and move any unrelated configuration updates into separate pull requests. Streamlining the scope will simplify review and ensure clear alignment with the linked issue.
Title Check ❓ Inconclusive The title correctly highlights disabling automatic .sln file creation, which is the core change, but the phrase “+ some other settings changes” is vague and does not describe the additional modifications, reducing clarity for someone scanning the history. A more descriptive or focused title would better convey the scope and intent of the pull request. Please consider revising the title to either omit the generic reference to “some other settings changes” or explicitly name any secondary modifications for better clarity and precision.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues Check ✅ Passed The pull request updates .vscode/settings.json to set "dotnet.automaticallyCreateSolutionInWorkspace": false, which precisely fulfills the primary requirement of issue #6492. No coding-level aspects of the linked issue are missing or incorrectly implemented.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@o-l-a-v o-l-a-v changed the title VSCode - Don't create .sln project file automatically VSCode - Don't create .sln project file automatically + some other settings changes Oct 13, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.vscode/settings.json (1)

2-5: Fix typo; optionally set default formatter for PowerShell.

  • Typo: “constistency” → “consistency”.
  • Optional: ensure the PowerShell formatter is used on save.
-    // Apply formatting on save for constistency
+    // Apply formatting on save for consistency
     "[powershell]": {
-        "editor.formatOnSave": true
+        "editor.formatOnSave": true,
+        "editor.defaultFormatter": "ms-vscode.powershell"
     },
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 16ca5b1 and ee5ffcc.

📒 Files selected for processing (1)
  • .vscode/settings.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (3)
.vscode/settings.json (3)

17-18: LGTM: final newline on save.

Good editor hygiene; complements inconsistent .editorconfig cases.


20-27: Confirm PSScriptAnalyzer settingsPath: File exists at ../PSScriptAnalyzerSettings.psd1 relative to .vscode; settingsPath is correct.


6-7: No changes needed: “dotnet.automaticallyCreateSolutionInWorkspace” is correct and provided by the C# Dev Kit extension to disable automatic .sln creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant