Install flex into build manylinux container #2365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
commented
Dec 1, 2025
ScottTodd
commented
Dec 1, 2025
This reverts commit 3dd1f78.
dgaliffiAMD
approved these changes
Dec 2, 2025
1 task
dgaliffiAMD
added a commit
that referenced
this pull request
Dec 3, 2025
## Motivation To use the latest `therock_build_manylinux_x86_64` docker image created with #2365 to resolve #2364. ## Technical Details Update the previous SHA, `4af52d56d91ef6ef8b7d0a13c6115af1ab2c9bf4a8a85d9267b489ecb737ed25`, to the latest, `583d473f263a289222c48d4b493e2956b2354a45796f09dee6f2c8ecd4504ab6`. ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> Run workflows with the new image. ## Test Result <!-- Briefly summarize test outcomes. --> Workflows passing. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. Signed-off-by: David Galiffi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I suspect this will help with #2364 :
Technical Details
Once merged and a new image is built we will need to update pins like here:
TheRock/.github/workflows/release_portable_linux_packages.yml
Line 148 in f4e3c62
Test Plan
I don't have a Linux development environment easily accessible to test this right now but here's what I would do:
Alternately, we could merge this without testing and then update the workflows and hope for the best...
Test Result
On local setup, reproduced initial failure on gfx950, installed
flex, rebuild was successful.Submission Checklist