Bump 1.3.1 #72
Bump 1.3.1 #72
Conversation
Signed-off-by: Hyungyu Kim <[email protected]>
Signed-off-by: Hyungyu Kim <[email protected]>
Cmake fix for buildfarm
Signed-off-by: Hyungyu Kim <[email protected]>
change name of variable
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @robotpilot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on bumping the version of several turtlebot3 application packages to 1.3.1. This update includes a specific fix for a CMake error within the turtlebot3_panorama package, improving its build compatibility across different ROS 2 distributions by refining how it detects the active ROS 2 version.
Highlights
- Version Bump: The version number has been updated to
1.3.1across allpackage.xml,setup.py, andCHANGELOG.rstfiles for theturtlebot3_applicationsmetapackage and its constituent packages, includingturtlebot3_aruco_tracker,turtlebot3_automatic_parking,turtlebot3_automatic_parking_vision,turtlebot3_follower,turtlebot3_panorama, andturtlebot3_yolo_object_detection. - CMake Fix in
turtlebot3_panorama: Theturtlebot3_panorama/CMakeLists.txtfile has been modified to improve ROS 2 distribution detection. It now checks for the existence of/opt/ros/humbleto defineROS2_HUMBLEand usesROS2_LATESTotherwise, removing previous reliance on theROS_DISTROenvironment variable which could be unreliable. cv_bridgeInclude Update: The conditional include forcv_bridge.hppinturtlebot3_panorama/include/turtlebot3_panorama/panorama.hpphas been adjusted to use the newROS2_LATESTmacro instead ofROS2_JAZZY_OR_ROLLING, aligning with the CMake changes for ROS 2 distribution detection.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the package versions from 1.3.0 to 1.3.1 across multiple TurtleBot3 packages while also updating some ROS2-specific build definitions in the panorama package.
- Update version numbers in setup.py, package.xml, and CHANGELOG.rst for several packages
- Replace outdated ROS2 macro definitions in turtlebot3_panorama's CMakeLists.txt and header files
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| turtlebot3_yolo_object_detection/setup.py | Version bump to 1.3.1 |
| turtlebot3_yolo_object_detection/package.xml | Version bump to 1.3.1 |
| turtlebot3_yolo_object_detection/CHANGELOG.rst | New changelog entry added |
| turtlebot3_panorama/package.xml | Version bump to 1.3.1 |
| turtlebot3_panorama/include/turtlebot3_panorama/panorama.hpp | Update macro conditional from ROS2_JAZZY_OR_ROLLING to ROS2_LATEST |
| turtlebot3_panorama/CMakeLists.txt | Simplified ROS distro check and updated definitions |
| turtlebot3_panorama/CHANGELOG.rst | New changelog entry added with fix details |
| turtlebot3_follower/package.xml | Version bump to 1.3.1 |
| turtlebot3_follower/CHANGELOG.rst | New changelog entry added |
| turtlebot3_automatic_parking_vision/setup.py | Version bump to 1.3.1 |
| turtlebot3_automatic_parking_vision/package.xml | Version bump to 1.3.1 |
| turtlebot3_automatic_parking_vision/CHANGELOG.rst | New changelog entry added |
| turtlebot3_automatic_parking/setup.py | Version bump to 1.3.1 |
| turtlebot3_automatic_parking/package.xml | Version bump to 1.3.1; description typo present |
| turtlebot3_automatic_parking/CHANGELOG.rst | New changelog entry added |
| turtlebot3_aruco_tracker/setup.py | Version bump to 1.3.1 |
| turtlebot3_aruco_tracker/package.xml | Version bump to 1.3.1 |
| turtlebot3_aruco_tracker/CHANGELOG.rst | New changelog entry added |
| turtlebot3_applications/package.xml | Version bump to 1.3.1 |
| turtlebot3_applications/CHANGELOG.rst | New changelog entry added with fix details |
| <version>1.3.0</version> | ||
| <version>1.3.1</version> | ||
| <description> | ||
| Package for turtlebot3 automatic_parking. You need a reflective tape and real robots. You can see parking spot using this pacakge on rviz. |
There was a problem hiding this comment.
Typo in 'pacakge'; please change it to 'package' to improve the clarity of the package description.
| Package for turtlebot3 automatic_parking. You need a reflective tape and real robots. You can see parking spot using this pacakge on rviz. | |
| Package for turtlebot3 automatic_parking. You need a reflective tape and real robots. You can see parking spot using this package on rviz. |
There was a problem hiding this comment.
Code Review
This pull request primarily bumps the version to 1.3.1 across multiple TurtleBot3 application packages. The main code modification is in turtlebot3_panorama/CMakeLists.txt and its corresponding header, altering the ROS distribution detection logic. The new method's reliance on filesystem checks and a generic ROS2_LATEST definition introduces potential robustness and future-proofing concerns compared to the previous ROS_DISTRO-based approach.
| if(EXISTS "/opt/ros/humble") | ||
| add_definitions(-DROS2_HUMBLE) | ||
| elseif(ROS_DISTRO STREQUAL "jazzy" OR ROS_DISTRO STREQUAL "rolling") | ||
| add_definitions(-DROS2_JAZZY_OR_ROLLING) | ||
| message("Humble") | ||
| else() | ||
| add_definitions(-DROS2_LATEST) | ||
| message("Latest") | ||
| endif() |
There was a problem hiding this comment.
The updated method for ROS distribution detection, while simpler, relies on the existence of /opt/ros/humble. This might not be robust as it assumes a standard ROS installation path. Consider prioritizing ROS_DISTRO and falling back to the EXISTS check for broader compatibility. Could you elaborate on the cmake error this change addresses?
| add_definitions(-DROS2_LATEST) | ||
| message("Latest") |
There was a problem hiding this comment.
Defining ROS2_LATEST for all non-Humble distributions assumes that all subsequent ROS 2 versions will share the same characteristics. Add a comment clarifying this assumption, especially regarding the cv_bridge.hpp include style used by Jazzy/Rolling.
| #ifdef ROS2_HUMBLE | ||
| #include <cv_bridge/cv_bridge.h> | ||
| #elif defined(ROS2_JAZZY_OR_ROLLING) | ||
| #elif defined(ROS2_LATEST) |
There was a problem hiding this comment.
Consider adding a comment to this line to explicitly state the assumption that all non-Humble ROS 2 distributions (covered by ROS2_LATEST) use the <cv_bridge/cv_bridge.hpp> header path.
| #elif defined(ROS2_LATEST) | |
| #elif defined(ROS2_LATEST) // Assumes cv_bridge.hpp for all non-Humble ROS 2 distributions |
No description provided.