Skip to content

Conversation

@ncdiehl11
Copy link
Collaborator

Overview

Fix the logical check for currying configureNozzleLayout in replaceTip, extending to 8-channel pipettes.

Closes RQA-4918

Test Plan and Hands on Testing

  • upload protocol from ticket
  • verify that tiprack state updates properly by inspecting tip state at each step (single channel pickups)

Changelog

  • curry configureNozzleLayout for any non-single-channel pipettes (previously only 96)

Review requests

  • see test plan

Risk assessment

low

…tial tip

Fix the logical check for currying `configureNozzleLayout` in `replaceTip`, extending to 8-channel pipettes.

Closes RQA-4918
@ncdiehl11 ncdiehl11 self-assigned this Nov 26, 2025
@ncdiehl11 ncdiehl11 marked this pull request as ready for review November 26, 2025 19:37
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.43%. Comparing base (6670cc0) to head (10096c4).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           chore_release-pd-8.7.0   #20254    +/-   ##
========================================================
  Coverage                   25.42%   25.43%            
========================================================
  Files                        3619     3615     -4     
  Lines                      300925   300626   -299     
  Branches                    42179    42170     -9     
========================================================
- Hits                        76525    76462    -63     
+ Misses                     224379   224143   -236     
  Partials                       21       21            
Flag Coverage Δ
protocol-designer 19.24% <100.00%> (+0.03%) ⬆️
step-generation 5.56% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...eration/src/commandCreators/compound/replaceTip.ts 74.34% <100.00%> (ø)

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants