Cherry-pick: Aggregate on collection property using custom methods (#3339) #3391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds (OData#3339) * Fixes OData#3329: aggregate on collection proprety using custom methods
xuzhg
reviewed
Oct 23, 2025
| { | ||
| var argument = EdmCoreModel.GetCollection(EdmCoreModel.Instance.GetDate(/*isNullable*/false)); | ||
| var existingCustomFunctionSignature = new FunctionSignatureWithReturnType(argument, argument); | ||
| CustomUriFunctions.AddCustomUriFunction(customFunctionName, existingCustomFunctionSignature); |
Member
There was a problem hiding this comment.
I don't think this can pass the compile. See my PR.
xuzhg
reviewed
Oct 23, 2025
| { | ||
| var argument = EdmCoreModel.GetCollection(EdmCoreModel.Instance.GetDate(/*isNullable*/false)); | ||
| var existingCustomFunctionSignature = new FunctionSignatureWithReturnType(argument, argument); | ||
| CustomUriFunctions.AddCustomUriFunction(customFunctionName, existingCustomFunctionSignature); |
Member
There was a problem hiding this comment.
Since @gathogojr updates the Custom Uri Function, I don't this can pass the build/compile
Member
|
@gathogojr I didn't realize that you have this cherry pick. I also create a PR to cherry pick with some changes since the CustomUriFunction register has changed in dev-9.x. If you want to update your PR, please close my PR. Otherwise, please take a look my PR and move that forward. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick: Aggregate on collection property using custom methods (#3339)
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.
Repository notes
Team members can start a CI build by adding a comment with the text
/AzurePipelines runto a PR. A bot may respond indicating that there is no pipeline associated with the pull request. This can be ignored if the build is triggered.Team members should not trigger a build this way for pull requests coming from forked repositories. They should instead trigger the build manually by setting the "branch" to
refs/pull/{prId}/mergewhere{prId}is the ID of the PR.