fix: Memory leak issue of nginx module #366
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
it's difficult to see what has actually changed given that the patch contains mostly unwanted formatting changes. Can you re-submit with just the memory-leak fixes please? |
Author
|
I'll resubmit it once again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone, during the long-term operation of the nginx-mapcache module, I discovered a persistent increase in memory usage issue. Even after using the nginx -s reload command, the memory usage did not decrease. According to the PR, I judged that it might be a problem with this part of the code. I modified this part of the code based on the official recommendations of APR. Currently, it seems that the memory usage of nginx is relatively stable.