feat: add TV client endpoints and nodes to get content with default OAuth2 Login #872
Conversation
|
Regarding the failing test, locally it works. ;) |
absidue
left a comment
absidue
left a comment
There was a problem hiding this comment.
This pull request is absolutely massive, it would definitely be a lot more sensible to split it out into multiple smaller ones, especially because it contains some changes that have nothing to do with the TV nodes like the watch history stuff.
Here are a list of things that definitely need to change before it could be considered mergable (not sure it if should be considering that it adds lots of nodes and bloat that many users of the library probably won't even need) but it definitely should be split up into multiple pull requests.
|
Additionally please change the commit messages to say feat instead of chore, release please looks at the commit messages so if this were to be merged, then it would get logged as a chore and not a feature implementation. |
|
@Duell10111 This PR is quite large, so I'll be helping you with it very soon. I'm also interested in getting OAuth working again, but we may need to make improvements in a few places. |
Thank you, I would be glad to get help. |
Duell10111
force-pushed
the
tv-endpoints-adaption
branch
2 times, most recently
from
ef1c19d to
1b77fbb
Compare
|
Is there anything I could help with here to get some progress? |
|
This PR has been automatically marked as stale because it has not had recent activity. Remove the stale label or comment or this will be closed in 2 days |
Duell10111
force-pushed
the
tv-endpoints-adaption
branch
2 times, most recently
from
628c1df to
3e304b5
Compare
|
Can we do sth to get this merged? @LuanRT |
absidue
left a comment
absidue
left a comment
There was a problem hiding this comment.
As these apply to multiple places I'll mention them here:
- Please remove the commented out code.
Parser.parseArray()never returnsnullso please removenullfrom the types on the properties that you assign the results ofParser.parseArray()to.- Please replace all uses of the
first()helper method with[0], it isn't used throughout the rest of the codebase anymore and only still exists because it is known to be used by users of YouTube.js. - Please move the 4 parser classes with the
Tvprefix into asrc/parser/classes/tvsubfolder, as YouTube's naming of them indicates that they are TV client specific.
| async addToWatchHistory(): Promise<Response> { | ||
| return super.addToWatchHistory(); | ||
| } |
There was a problem hiding this comment.
As this is meant to be TV specific, you should probably pass the relevant parameters.
There was a problem hiding this comment.
Added the TV Client params
|
@Duell10111 FYI there are still some open points from my last review (pinging you because your last commit was 20 days ago). |
Duell10111
force-pushed
the
tv-endpoints-adaption
branch
from
c8f68a5 to
3ad1592
Compare
|
@absidue Your open points should be handled now. :) |
This comment was marked as outdated.
This comment was marked as outdated.
Duell10111
force-pushed
the
tv-endpoints-adaption
branch
from
a8243a6 to
1bf63f6
Compare
4 participants
As reaction to the block of the classic TV OAuth authentication on non TV endpoints, I tried to add Helper classes with TV Client optimization.
Related issue: #803
As I am not an expert of the Innertube API and the Youtube.js library, feel free to optimize or bring up suggestions of this PR.
Therefore this PR is created as draft. :)
Additionally regarding TV endpoints, I added a new function to adapt watched time for videos added to the watch list (history). (Issue: #825)
Further for the TV client I added a helper function to get the continuation of HorizontalList as needed for the TV Homefeed. :)