Skip to content

Conversation

@mitsuki31
Copy link
Contributor

Just adding the parser class for #978. The issue was also rarely happened to me, where the playabilityStatus.status is UNPLAYABLE.

I'm not saying this will address the issue, but hope this help adding the parser class.

Copy link
Collaborator

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Text.fromAttributed for all properties in that node.

This change includes:
- Changed the properties type in `PlayerCaptchaView` parser class to
  `AttributedText` instead a plain object
- Fixed any mismatched property name (`style_runs`) to their correct
  name (`styleRuns`).
@mitsuki31
Copy link
Contributor Author

Hi @absidue, I’ve applied the requested changes to the code. Could you please review them when you get a chance? I’ll be happy to make any further adjustments if something is incorrect or missing. Thanks!

@absidue
Copy link
Collaborator

absidue commented Oct 12, 2025

@mitsuki31 The requested change was for you to use the Text.fromAttributed() method that returns instances of the Text class, whereas you just passed through the input data and applied a TypeScript type to it. So as it currently stands the requested changed are still missing.

…orrectly

Replaced incorrect usage of `AttributedText` with the proper `Text` class
and updated property assignments using `Text.fromAttributed()`.
This corrects a misunderstanding from the previous implementation.
@mitsuki31
Copy link
Contributor Author

@absidue Sorry for the late reply, and also for the earlier changes; I misunderstood your request. I've updated the code now, and this version should be correct.
When you get a chance, could you take another look? Thanks!

Once again, I’m sorry about the confusion, and I’ll definitely learn from the mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants